Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2806853002: Re-enable StrictMode for VR e2e tests (Closed)

Created:
3 years, 8 months ago by bsheedy
Modified:
3 years, 8 months ago
CC:
chromium-reviews, bajones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable StrictMode for VR e2e tests The upgrade to VRCore 1.4 seems to have resolved the StrictMode violations on their end, so re-enable StrictMode checking to check for legitimate browser violations. BUG=692816 Review-Url: https://codereview.chromium.org/2806853002 Cr-Commit-Position: refs/heads/master@{#463096} Committed: https://chromium.googlesource.com/chromium/src/+/e2a2e605169bf31e451e1dc3f8e3e245c6fc18e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M testing/buildbot/chromium.fyi.json View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bsheedy
+kbr for testing/buildbot OWNERS
3 years, 8 months ago (2017-04-07 21:55:38 UTC) #2
Ken Russell (switch to Gerrit)
lgtm Sure hope other VR/WebVR owners are aware of this change. I strongly recommend linking ...
3 years, 8 months ago (2017-04-08 00:01:21 UTC) #3
bsheedy
On 2017/04/08 00:01:21, Ken Russell wrote: > lgtm > > Sure hope other VR/WebVR owners ...
3 years, 8 months ago (2017-04-08 00:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806853002/1
3 years, 8 months ago (2017-04-08 00:04:43 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 01:16:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2a2e605169bf31e451e1dc3f8e3...

Powered by Google App Engine
This is Rietveld 408576698