Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2806793002: Cache API tests: prepopulate cache in deterministic order (Closed)

Created:
2 years, 8 months ago by jsbell
Modified:
2 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache API tests: prepopulate cache in deterministic order Chrome and Firefox differ in the order in which cache keys() are returned. Chrome orders by according to when the put()s were issued. Firefox orders by when the body is complete. The test helper prepopulated_cache_test did not guarantee that these matched, leading to the tests being flaky in Firefox. This change tweaks the helper so that the put()s are processed serially so that the order is deterministic for both. Spec issue: https://github.com/w3c/ServiceWorker/issues/823 BUG=655479 Review-Url: https://codereview.chromium.org/2806793002 Cr-Commit-Position: refs/heads/master@{#463195} Committed: https://chromium.googlesource.com/chromium/src/+/5136241948671b538965c783e8aee27e88037aa9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/resources/test-helpers.js View 1 chunk +13 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jsbell
foolip@ - can you review? (and cq if lg?) This should address the failure seen ...
2 years, 8 months ago (2017-04-07 21:02:01 UTC) #5
foolip
lgtm
2 years, 8 months ago (2017-04-10 07:26:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806793002/1
2 years, 8 months ago (2017-04-10 07:26:30 UTC) #10
commit-bot: I haz the power
2 years, 8 months ago (2017-04-10 08:26:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5136241948671b538965c783e8ae...

Powered by Google App Engine
This is Rietveld 408576698