ash: Do not constrain window bounds if requested

ash: Do not constrain window bounds if requested

If a client requests to set window bounds directly, Ash should not
interfere, e.g. by constraining them to the workspace size.

ARC windows are maximized to the display rather than the workspace.
However, Ash would constrain the ShellSurface bounds to the workspace
size. As a result, if the shelf was positioned to the left, the right
edge of the window would be displaced from that of the display by the
width of the shelf, so the app was unresponsive to input in that gap.

BUG=709616
TEST=Print window hierarchy using debug shortcut, and verify that the
     bounds of a maximized ShellSurface match the display bounds.

Review-Url: https://codereview.chromium.org/2806783002
Cr-Commit-Position: refs/heads/master@{#464242}
Committed: https://chromium.googlesource.com/chromium/src/+/ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76

[Dominik Laskowski, 2017-04-07 20:59:03]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 20:59:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2017-04-07 21:03:08]

domlaskowski@chromium.org changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[Dominik Laskowski, 2017-04-07 21:03:08]

PTAL.

[commit-bot: I haz the power, 2017-04-07 21:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:31:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dominik Laskowski, 2017-04-07 21:48:25]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:24:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:24:53]

Dry run: This issue passed the CQ dry run.

[mtomasz, 2017-04-11 02:36:36]

mtomasz@chromium.org changed reviewers:
+ mtomasz@chromium.org

[mtomasz, 2017-04-11 02:36:36]

I don't see any difference in Play store behavior before and after this patch
applied manually. Am I doing something wrong?

[mtomasz, 2017-04-11 04:06:51]

Ignore my question. I found the difference.

[reveman, 2017-04-11 16:43:32]

lgtm

[Dominik Laskowski, 2017-04-12 21:16:00]

Ping.

[Dominik Laskowski, 2017-04-12 21:16:02]

Ping.

[oshima, 2017-04-12 22:27:24]

lgtm

https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_window_state.cc:159: if
(window_state->allow_set_bounds_direct()) {
this is slate code. can you just remove this?

[oshima, 2017-04-12 22:27:44]

On 2017/04/12 22:27:24, oshima wrote:
> lgtm
> 
>
https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
> File ash/common/wm/maximize_mode/maximize_mode_window_state.cc (right):
> 
>
https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
> ash/common/wm/maximize_mode/maximize_mode_window_state.cc:159: if
> (window_state->allow_set_bounds_direct()) {
> this is slate code. can you just remove this?

s/slate/stale/

[Dominik Laskowski, 2017-04-12 22:44:04]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:44:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2017-04-12 22:45:40]

https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/2806783002/diff/20001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_window_state.cc:159: if
(window_state->allow_set_bounds_direct()) {
On 2017/04/12 22:27:24, oshima wrote:
> this is slate code. can you just remove this?

Done.

[commit-bot: I haz the power, 2017-04-12 23:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:25:00]

Dry run: This issue passed the CQ dry run.

[Dominik Laskowski, 2017-04-12 23:42:25]

The CQ bit was checked by domlaskowski@chromium.org

[Dominik Laskowski, 2017-04-12 23:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2806783002/#ps40001
(title: "Remove dead code")

[commit-bot: I haz the power, 2017-04-12 23:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:06:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492040545794330,
"parent_rev": "03323c74be50811df1ac0056087f19c7cf69a832", "commit_rev":
"ef7d5fbdaadfd3c2ed18d662d2ef754e5d208c76"}

[commit-bot: I haz the power, 2017-04-13 02:07:06]

Description was changed from

==========
ash: Do not constrain window bounds if requested

If a client requests to set window bounds directly, Ash should not
interfere, e.g. by constraining them to the workspace size.

ARC windows are maximized to the display rather than the workspace.
However, Ash would constrain the ShellSurface bounds to the workspace
size. As a result, if the shelf was positioned to the left, the right
edge of the window would be displaced from that of the display by the
width of the shelf, so the app was unresponsive to input in that gap.

BUG=709616
TEST=Print window hierarchy using debug shortcut, and verify that the
     bounds of a maximized ShellSurface match the display bounds.
==========

to

==========
ash: Do not constrain window bounds if requested

If a client requests to set window bounds directly, Ash should not
interfere, e.g. by constraining them to the workspace size.

ARC windows are maximized to the display rather than the workspace.
However, Ash would constrain the ShellSurface bounds to the workspace
size. As a result, if the shelf was positioned to the left, the right
edge of the window would be displaced from that of the display by the
width of the shelf, so the app was unresponsive to input in that gap.

BUG=709616
TEST=Print window hierarchy using debug shortcut, and verify that the
     bounds of a maximized ShellSurface match the display bounds.

Review-Url: https://codereview.chromium.org/2806783002
Cr-Commit-Position: refs/heads/master@{#464242}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef7d5fbdaadfd3c2ed18d662d2ef...
==========

[commit-bot: I haz the power, 2017-04-13 02:07:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ef7d5fbdaadfd3c2ed18d662d2ef...