PrintBrowser: Pick page size based on the default language.

PrintBrowser: Pick page size based on the default language.

Review-Url: https://codereview.chromium.org/2806643002
Cr-Commit-Position: refs/heads/master@{#463367}
Committed: https://chromium.googlesource.com/chromium/src/+/543ec2bd770a4cc0e392af4add3bcceb1c00afcf

[nainar, 2017-04-06 22:23:29]

nainar@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2017-04-06 22:23:30]

LGTM! :)

[Lei Zhang, 2017-04-06 22:27:36]

thestig@chromium.org changed reviewers:
+ pdr@chromium.org

[Lei Zhang, 2017-04-06 22:27:36]

+pdr for OWNERS

This is the easiest thing to do without pulling in a stack of printing code, or
duplicating code in blink Locale implementations.

Right now printing/units.h is a mixture of constants and unit conversion
functions. If we extract constants to its own file, maybe we can allow that
header to be included via DEPS. Then we can remove the constants in
FrameView.cpp.

[pdr., 2017-04-10 01:37:26]

On 2017/04/06 at 22:27:36, thestig wrote:
> +pdr for OWNERS
> 
> This is the easiest thing to do without pulling in a stack of printing code,
or duplicating code in blink Locale implementations.
> 
> Right now printing/units.h is a mixture of constants and unit conversion
functions. If we extract constants to its own file, maybe we can allow that
header to be included via DEPS. Then we can remove the constants in
FrameView.cpp.

LGTM

[Lei Zhang, 2017-04-10 17:42:07]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:45:49]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Zhang, 2017-04-10 18:07:06]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-04-10 18:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2806643002/#ps20001
(title: "Post great-rename rebase")

[commit-bot: I haz the power, 2017-04-10 18:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:42:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491847626302570,
"parent_rev": "2c41f41b27d5cf1f0595a0f591cfff06664cbd7d", "commit_rev":
"543ec2bd770a4cc0e392af4add3bcceb1c00afcf"}

[commit-bot: I haz the power, 2017-04-10 19:43:42]

Description was changed from

==========
PrintBrowser: Pick page size based on the default language.
==========

to

==========
PrintBrowser: Pick page size based on the default language.

Review-Url: https://codereview.chromium.org/2806643002
Cr-Commit-Position: refs/heads/master@{#463367}
Committed:
https://chromium.googlesource.com/chromium/src/+/543ec2bd770a4cc0e392af4add3b...
==========

[commit-bot: I haz the power, 2017-04-10 19:43:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/543ec2bd770a4cc0e392af4add3b...