Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2806633002: [Home] Only use thick progress bar on older Android versions (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Only use thick progress bar on older Android versions The reason for using the thick version of the progress bar was to make it more visible against a black status bar. With recent Chrome Home changes, the status bar is a much lighter color making the progress bar easy to see and eliminating the need for it to be as large. This change reduces the progress bar size for android M and above since these versions allow themed status bars. BUG=708680 Review-Url: https://codereview.chromium.org/2806633002 Cr-Commit-Position: refs/heads/master@{#462871} Committed: https://chromium.googlesource.com/chromium/src/+/762665735a6a687e05be93f934d82a814740b24d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 8 months ago (2017-04-06 22:58:03 UTC) #2
Theresa
lgtm
3 years, 8 months ago (2017-04-06 23:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806633002/1
3 years, 8 months ago (2017-04-07 15:13:16 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:50:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/762665735a6a687e05be93f934d8...

Powered by Google App Engine
This is Rietveld 408576698