Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 280663002: Adds dashboard link for one-line plot on each alert item. (Closed)

Created:
6 years, 7 months ago by benchen
Modified:
6 years, 7 months ago
Reviewers:
kelvinly
CC:
skia-review_googlegroups.com, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adds dashboard link for one-line plot on each alert item. BUG=skia:2523 NOTRY=true TBR=rmistry@google.com Committed: http://code.google.com/p/skia/source/detail?r=14713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M bench/check_bench_regressions.py View 3 chunks +8 lines, -0 lines 0 comments Download
M tools/tests/benchalerts/Perf-Android-Nexus7-Tegra3-Arm7-Release/output-expected/stderr View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
benchen
The URLs in the test don't work because we no longer show "record" configs, but ...
6 years, 7 months ago (2014-05-13 15:18:33 UTC) #1
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 7 months ago (2014-05-13 16:39:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/280663002/1
6 years, 7 months ago (2014-05-13 16:40:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 16:40:13 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-13 16:40:14 UTC) #5
kelvinly
LGTM
6 years, 7 months ago (2014-05-13 17:11:05 UTC) #6
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-13 17:11:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/280663002/1
6 years, 7 months ago (2014-05-13 17:11:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 17:11:57 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-13 17:11:57 UTC) #10
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-13 17:37:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/280663002/1
6 years, 7 months ago (2014-05-13 17:38:11 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:38:19 UTC) #13
Message was sent while issue was closed. 
Change committed as 14713

Powered by Google App Engine
This is Rietveld 408576698