Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: bench/check_bench_regressions.py

Issue 280663002: Adds dashboard link for one-line plot on each alert item. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/tests/benchalerts/Perf-Android-Nexus7-Tegra3-Arm7-Release/output-expected/stderr » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/check_bench_regressions.py
diff --git a/bench/check_bench_regressions.py b/bench/check_bench_regressions.py
index 86ead549579eb49de9d2b4ecc094769d34d8ca74..ea9146421a087cc225dd252404e2a083c6d49098 100644
--- a/bench/check_bench_regressions.py
+++ b/bench/check_bench_regressions.py
@@ -28,6 +28,9 @@ UB_IDX = -1
SLOWER = 0
FASTER = 1
+# URL prefix for the bench dashboard page. Showing recent 15 days of data.
+DASHBOARD_URL_PREFIX = 'http://go/skpdash/#15'
+
def usage():
"""Prints simple usage information."""
@@ -147,6 +150,9 @@ def check_expectations(lines, expectations, key_suffix):
for line in lines:
line_str = str(line)
line_str = line_str[ : line_str.find('_{')]
+ # Extracts bench and config from line_str, which is in the format
+ # <bench-picture-name>.skp_<config>_
+ bench, config = line_str.strip('_').split('.skp_')
bench_platform_key = line_str + ',' + key_suffix
if bench_platform_key not in expectations:
continue
@@ -157,6 +163,8 @@ def check_expectations(lines, expectations, key_suffix):
exception = 'Bench %s out of range [%s, %s] (%s vs %s, %s%%).' % (
bench_platform_key, this_min, this_max, this_bench_value,
this_expected, (off_ratio - 1) * 100)
+ exception += '\n' + '~'.join([
+ DASHBOARD_URL_PREFIX, bench, platform, config])
if off_ratio > 1: # Bench is slower.
exceptions[SLOWER].setdefault(off_ratio, []).append(exception)
else:
« no previous file with comments | « no previous file | tools/tests/benchalerts/Perf-Android-Nexus7-Tegra3-Arm7-Release/output-expected/stderr » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698