third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp - Issue 2806623004: Worker: Introduce per-global-scope task scheduler

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

Issue 2806623004: Worker: Introduce per-global-scope task scheduler (Closed)

Patch Set: remove unused header Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/core/dom/TaskRunnerHelper.h ('K') | « third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerBackingThread.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

index 631b8afe68957805afd28043d8c512aef81e5822..7b6441d9e648be5ca73710482aaf231391b3cefd 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

@@ -36,6 +36,7 @@

#include "bindings/core/v8/V8GCController.h"

#include "core/dom/Document.h"

#include "core/dom/ExecutionContext.h"

+#include "core/dom/TaskRunnerHelper.h"

#include "core/events/MessageEvent.h"

#include "core/inspector/ConsoleMessage.h"

#include "core/workers/InProcessWorkerMessagingProxy.h"

@@ -122,7 +123,7 @@ void InProcessWorkerObjectProxy::DidCreateWorkerGlobalScope(

DCHECK(!worker_global_scope_);

worker_global_scope_ = ToWorkerGlobalScope(global_scope);

timer_ = WTF::MakeUnique<TaskRunnerTimer<InProcessWorkerObjectProxy>>(

- Platform::Current()->CurrentThread()->GetWebTaskRunner(), this,

+ TaskRunnerHelper::Get(TaskType::kUnspecedTimer, global_scope), this,

haraken 2017/04/17 14:49:52 Sorry for my previous comment but I begin to think

altimin 2017/04/18 00:46:40 Should we make a special GC task type? It seems th

nhiroki 2017/04/18 05:34:38 Yeah, that makes sense. Replaced.

haraken 2017/04/18 07:29:38 I'm slightly negative about increasing # of unspec

nhiroki 2017/04/19 06:35:59 Thank you for the comment. For the record I copied

&InProcessWorkerObjectProxy::CheckPendingActivity);

}