Worker: Introduce per-global-scope task scheduler

third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "core/workers/InProcessWorkerObjectProxy.h"
 
 #include <memory>
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SourceLocation.h"
 #include "bindings/core/v8/V8GCController.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
+#include "core/dom/TaskRunnerHelper.h"
 #include "core/events/MessageEvent.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/workers/InProcessWorkerMessagingProxy.h"
 #include "core/workers/ParentFrameTaskRunners.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "platform/CrossThreadFunctional.h"
 #include "platform/WebTaskRunner.h"
 #include "platform/wtf/Functional.h"
 #include "platform/wtf/PtrUtil.h"
@@ skipping 66 matching lines @@
           CrossThreadBind(&InProcessWorkerMessagingProxy::DispatchErrorEvent,
                           messaging_proxy_weak_ptr_, error_message,
                           WTF::Passed(location->Clone()), exception_id));
 }
 
 void InProcessWorkerObjectProxy::DidCreateWorkerGlobalScope(
     WorkerOrWorkletGlobalScope* global_scope) {
   DCHECK(!worker_global_scope_);
   worker_global_scope_ = ToWorkerGlobalScope(global_scope);
   timer_ = WTF::MakeUnique<TaskRunnerTimer<InProcessWorkerObjectProxy>>(
-      Platform::Current()->CurrentThread()->GetWebTaskRunner(), this,
+      TaskRunnerHelper::Get(TaskType::kUnspecedTimer, global_scope), this,

[haraken, 2017/04/17 14:49:52]

Sorry for my previous comment but I begin to think that this timer task should
not be throttled (otherwise, the GC timing will be delayed). Would it make sense
to use kUnthrottled?

[altimin, 2017/04/18 00:46:40]

Should we make a special GC task type? It seems that GC tasks have been
mentioned on a number of occasions.

[nhiroki, 2017/04/18 05:34:38]

Yeah, that makes sense. Replaced.
SGTM. I added a TODO comment and filed an issue (https://crbug.com/712504)

[haraken, 2017/04/18 07:29:38]

I'm slightly negative about increasing # of unspeced tasks. Unless we're
planning to treat GC tasks in a special manner, I'd prefer just using
Unthrottled.

[nhiroki, 2017/04/19 06:35:59]

Thank you for the comment. For the record I copied-and-pasted your comment in
the issue.

       &InProcessWorkerObjectProxy::CheckPendingActivity);
 }
 
 void InProcessWorkerObjectProxy::DidEvaluateWorkerScript(bool) {
   StartPendingActivityTimer();
 }
 
 void InProcessWorkerObjectProxy::WillDestroyWorkerGlobalScope() {
   timer_.reset();
   worker_global_scope_ = nullptr;
@@ skipping 42 matching lines @@
   // There is still a pending activity. Check it later.
   StartPendingActivityTimer();
 }
 
 WeakPtr<ThreadedMessagingProxyBase>
 InProcessWorkerObjectProxy::MessagingProxyWeakPtr() {
   return messaging_proxy_weak_ptr_;
 }
 
 }  // namespace blink