Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2806603002: Remove RenderFrameHost pointer from ChooserController. (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Remove RenderFrameHost pointer from ChooserController. This change removes the raw RenderFrameHost pointer from ChooserController and instead either computes necessary values (such as the title) at construction time or stores a weak pointer to the object derived from the RenderFrameHost. BUG=697486 Review-Url: https://codereview.chromium.org/2746313002 Cr-Commit-Position: refs/heads/master@{#456876} (cherry picked from commit f50d8d33c5da873242189cf73176d78a48549762) Review-Url: https://codereview.chromium.org/2806603002 . Cr-Commit-Position: refs/branch-heads/3029@{#616} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7832e106ed7e343da9583d92f325faa5bc21a2ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -120 lines) Patch
M chrome/browser/chooser_controller/chooser_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chooser_controller/chooser_controller.cc View 2 chunks +25 lines, -16 lines 0 comments Download
M chrome/browser/chooser_controller/mock_chooser_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chooser_controller/mock_chooser_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/device_chooser_content_view_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/usb/usb_chooser_context.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/usb/usb_chooser_context.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_controller.h View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/usb/usb_chooser_controller.cc View 9 chunks +41 lines, -36 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.cc View 5 chunks +25 lines, -47 lines 0 comments Download
M device/usb/webusb_descriptors.h View 2 chunks +6 lines, -2 lines 0 comments Download
M device/usb/webusb_descriptors.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
3 years, 8 months ago (2017-04-06 21:43:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7832e106ed7e343da9583d92f325faa5bc21a2ae.

Powered by Google App Engine
This is Rietveld 408576698