Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2806593005:
Trigger linux_layout_tests_layout_ng for LayoutNG changes (Closed)
DescriptionTrigger linux_layout_tests_layout_ng for LayoutNG changes
Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test
bot, linux_layout_tests_layout_ng, which runs all layout tests with NG.
R=thakis@chromium.org
BUG=706183
Review-Url: https://codereview.chromium.org/2806593005
Cr-Commit-Position: refs/heads/master@{#463177}
Committed: https://chromium.googlesource.com/chromium/src/+/ab81cf5d84d85f10c48b1c02dc9e8999df8928a3
Patch Set 1 #
Messages
Total messages: 20 (7 generated)
The CQ bit was checked by eae@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Modeled on the spv2 trigger but I'm the first to admit that I have no idea what I'm doing here. Suggestions *very* welcome!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It looks like that both is backed by a single slave, isn't that just going to melt? Do you have capacity estimation somewhere that suggests that one slave is enough?
On 2017/04/08 15:46:30, Nico wrote: > It looks like that both is backed by a single slave, isn't that just going to > melt? Do you have capacity estimation somewhere that suggests that one slave is > enough? * ...that bot is... Not "both". Phone keyboard, sorry.
On 2017/04/08 15:47:14, Nico wrote: > On 2017/04/08 15:46:30, Nico wrote: > > It looks like that both is backed by a single slave, isn't that just going to > > melt? Do you have capacity estimation somewhere that suggests that one slave > is > > enough? At the moment there are less than ten changes per day so a single slave should be sufficient.
One build can take an hour or longer, so unless the ten changes don't clump up at all a single slave feels a bit low to me. But I'm not super familiar with capacity planning for bots ... did you ask someone from infra for advice? If not, I'd suggest a quick thread on infra-dev to make sure troopers are aware, and to have someone familiar with capacity see the plan. With that, this looks fine (writing this in Gmail so can't lg for reals from here). On Apr 8, 2017 5:44 PM, <eae@chromium.org> wrote: > On 2017/04/08 15:47:14, Nico wrote: > > On 2017/04/08 15:46:30, Nico wrote: > > > It looks like that both is backed by a single slave, isn't that just > going > to > > > melt? Do you have capacity estimation somewhere that suggests that one > slave > > is > > > enough? > > At the moment there are less than ten changes per day so a single slave > should > be sufficient. > > > https://codereview.chromium.org/2806593005/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
One build can take an hour or longer, so unless the ten changes don't clump up at all a single slave feels a bit low to me. But I'm not super familiar with capacity planning for bots ... did you ask someone from infra for advice? If not, I'd suggest a quick thread on infra-dev to make sure troopers are aware, and to have someone familiar with capacity see the plan. With that, this looks fine (writing this in Gmail so can't lg for reals from here). On Apr 8, 2017 5:44 PM, <eae@chromium.org> wrote: > On 2017/04/08 15:47:14, Nico wrote: > > On 2017/04/08 15:46:30, Nico wrote: > > > It looks like that both is backed by a single slave, isn't that just > going > to > > > melt? Do you have capacity estimation somewhere that suggests that one > slave > > is > > > enough? > > At the moment there are less than ten changes per day so a single slave > should > be sufficient. > > > https://codereview.chromium.org/2806593005/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Talked to them and the paint team which did something similar with a single slave recently and we're fairly confident that it'll be enough for now. I do understand your concerns however. Thanks!
Lgtm Please watch the slave a bit during the day and check if builds queue up.
Will do, thank you!
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491801363775340, "parent_rev":
"358bb12a3d3b09dfad4cdd1e1bd0114feec6d32f", "commit_rev":
"ab81cf5d84d85f10c48b1c02dc9e8999df8928a3"}
Message was sent while issue was closed.
Description was changed from ========== Trigger linux_layout_tests_layout_ng for LayoutNG changes Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org BUG=706183 ========== to ========== Trigger linux_layout_tests_layout_ng for LayoutNG changes Change PRESUBMIT.py for third_party/WebKit to trigger the LayoutNG test bot, linux_layout_tests_layout_ng, which runs all layout tests with NG. R=thakis@chromium.org BUG=706183 Review-Url: https://codereview.chromium.org/2806593005 Cr-Commit-Position: refs/heads/master@{#463177} Committed: https://chromium.googlesource.com/chromium/src/+/ab81cf5d84d85f10c48b1c02dc9e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ab81cf5d84d85f10c48b1c02dc9e...
Message was sent while issue was closed.
Looks like the bot isn't quite configured correctly: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_t...
Message was sent while issue was closed.
Yeah, I got the flag wrong. https://bugs.chromium.org/p/chromium/issues/detail?id=706183#c12 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
