Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2806593003: Force update CCT Title when url is set if it only shows title (Closed)

Created:
3 years, 8 months ago by Yusuf
Modified:
3 years, 8 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Force update CCT Title when url is set if it only shows title In the mode where CCT only shows the page title, we should never have an empty title displayed. Force this by checking the title even if there are no title update after Toolbar creation since those updates might have been missing while prerendering. If there is no title set yet, post a callback to check this and fallback to showing the domain if there is not title set after a second. BUG=708957 Review-Url: https://codereview.chromium.org/2806593003 Cr-Commit-Position: refs/heads/master@{#463355} Committed: https://chromium.googlesource.com/chromium/src/+/e03e0c39a2a26eae5b0affe79522ce0c2e1b0a21

Patch Set 1 #

Patch Set 2 : Force another title update if title does get set #

Patch Set 3 : got rid of the fallback for cherrypicking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Yusuf
3 years, 8 months ago (2017-04-10 17:26:00 UTC) #12
Yusuf
3 years, 8 months ago (2017-04-10 17:26:29 UTC) #14
gone
lgtm
3 years, 8 months ago (2017-04-10 18:11:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806593003/40001
3 years, 8 months ago (2017-04-10 18:14:47 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:20:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e03e0c39a2a26eae5b0affe79522...

Powered by Google App Engine
This is Rietveld 408576698