Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2806593002: Remove layout tests that are now passing from FlagExpectations/site-per-process (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove layout tests that are now passing from FlagExpectations/site-per-process These two tests have been passing on our bots for a while, and flakiness dashboard is showing no flakes for either one. Note that plugintypes-affects-cross-site-child-disallowed.html doesn't appear to involve a CSP violation event, just the console warning, so it probably was not part of issue 611232 (which is still broken). BUG=670105 NOTRY=true Review-Url: https://codereview.chromium.org/2806593002 Cr-Commit-Position: refs/heads/master@{#463826} Committed: https://chromium.googlesource.com/chromium/src/+/f62584dc6a463324c181a09725dae46a824022f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
alexmos
Lukasz, can you please take a look? I've prepared this a couple of days ago, ...
3 years, 8 months ago (2017-04-10 23:44:10 UTC) #2
Łukasz Anforowicz
On 2017/04/10 23:44:10, alexmos wrote: > Lukasz, can you please take a look? > LGTM ...
3 years, 8 months ago (2017-04-11 21:53:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806593002/1
3 years, 8 months ago (2017-04-11 22:59:09 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 23:15:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f62584dc6a463324c181a09725da...

Powered by Google App Engine
This is Rietveld 408576698