Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2806493002: [heap] Move a few methods from spaces.h to spaces.cc (Closed)

Created:
3 years, 8 months ago by Jakob Kummerow
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move a few methods from spaces.h to spaces.cc To avoid the need for including list-inl.h when you include spaces.h Review-Url: https://codereview.chromium.org/2806493002 Cr-Commit-Position: refs/heads/master@{#44481} Committed: https://chromium.googlesource.com/v8/v8/+/8ce7898ddf159a02ed5af08234974c2b6d7262c6

Patch Set 1 #

Patch Set 2 : add V8_EXPORT_PRIVATE annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M src/heap/spaces.h View 1 1 chunk +6 lines, -14 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Jakob Kummerow
As discussed. PTAL.
3 years, 8 months ago (2017-04-06 14:47:56 UTC) #2
Michael Lippautz
lgtm
3 years, 8 months ago (2017-04-06 14:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806493002/20001
3 years, 8 months ago (2017-04-07 11:16:33 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 11:43:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8ce7898ddf159a02ed5af08234974c2b6d7...

Powered by Google App Engine
This is Rietveld 408576698