Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2806453002: Don't set a default value for the NTPContentSuggestionsEnabled policy if ChromeHome is enabled (Closed)

Created:
3 years, 8 months ago by Marc Treib
Modified:
3 years, 8 months ago
CC:
chromium-reviews, finkm, kingston, Kingston T
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set a default value for the NTPContentSuggestionsEnabled policy if ChromeHome is enabled This is a temporary hack to allow dogfooding of ChromeHome. BUG=708191 Review-Url: https://codereview.chromium.org/2806453002 Cr-Commit-Position: refs/heads/master@{#462451} Committed: https://chromium.googlesource.com/chromium/src/+/d4b92153f875c211e8c6f01603ed510962200747

Patch Set 1 #

Patch Set 2 : add bug #

Patch Set 3 : argh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_manager.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_manager.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Marc Treib
PTAL, and see the bug for more context/background. This is horrible and I hate it, ...
3 years, 8 months ago (2017-04-06 12:35:55 UTC) #8
Andrew T Wilson (Slow)
LGTM
3 years, 8 months ago (2017-04-06 13:11:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806453002/40001
3 years, 8 months ago (2017-04-06 13:25:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d4b92153f875c211e8c6f01603ed510962200747
3 years, 8 months ago (2017-04-06 13:34:13 UTC) #15
Marc Treib
3 years, 8 months ago (2017-04-13 08:20:15 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2813423002/ by treib@chromium.org.

The reason for reverting is: The hack isn't required anymore, let's get it
removed before branch point :).

Powered by Google App Engine
This is Rietveld 408576698