Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2806373004: Enable strict coverage for json, path, platform, properties, raw_io (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci1
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable strict coverage for json, path, platform, properties, raw_io BUG=chromium:693058 Review-Url: https://codereview.chromium.org/2806373004 Committed: https://github.com/luci/recipes-py/commit/f5e47cfc28b5964701572db12f96c7a5a3f1821a

Patch Set 1 #

Patch Set 2 : presubmit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1041 lines, -26 lines) Patch
M recipe_modules/json/__init__.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M recipe_modules/path/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
M recipe_modules/platform/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/properties/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/properties/example.py View 1 chunk +1 line, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/basic.json View 1 chunk +21 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_generic.json View 1 chunk +77 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_git_scheduled.json View 1 chunk +105 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_scheduled.json View 1 chunk +105 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver.json View 1 chunk +140 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json View 1 chunk +133 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_both.json View 1 chunk +133 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_gerrit.json View 1 chunk +133 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json View 1 chunk +133 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/dicts.json View 1 chunk +21 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/lists.json View 1 chunk +21 lines, -0 lines 0 comments Download
M recipe_modules/python/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
M recipe_modules/python/example.py View 1 chunk +2 lines, -0 lines 0 comments Download
M recipe_modules/python/example.expected/basic.json View 1 chunk +12 lines, -0 lines 0 comments Download
M recipe_modules/raw_io/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806373004/20001
3 years, 8 months ago (2017-04-10 18:57:07 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 18:57:08 UTC) #10
iannucci1
lgtm
3 years, 8 months ago (2017-04-10 19:11:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806373004/40001
3 years, 8 months ago (2017-04-10 21:04:04 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:07:45 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/f5e47cfc28b5964701572db12f96c7a5a3f...

Powered by Google App Engine
This is Rietveld 408576698