Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2806373003: Revert "🔍 Hide the Google G by default" (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer, PEConn
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "🔍 Hide the Google G by default" This reverts commit 1204d2395bf8818c777c3af005f046b9d11036b9. This introduced one bug and exposed another. Yay! BUG=709884, 709886 TBR=bauerb,peconn Review-Url: https://codereview.chromium.org/2806373003 Cr-Commit-Position: refs/heads/master@{#463356} Committed: https://chromium.googlesource.com/chromium/src/+/eee59d96815e380acf6bc106cc5ed7a43984fe03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -42 lines) Patch
M chrome/android/java/res/layout/location_bar.xml View 1 chunk +18 lines, -4 lines 0 comments Download
D chrome/android/java/res/layout/location_bar_google_g.xml View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java View 4 chunks +8 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806373003/1
3 years, 8 months ago (2017-04-10 18:13:30 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:22:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eee59d96815e380acf6bc106cc5e...

Powered by Google App Engine
This is Rietveld 408576698