Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2806353002: [ios] Move WebStateList to ios/chrome/browser/web_state_list. (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, ios-reviews+clean_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Move WebStateList to ios/chrome/browser/web_state_list. Only UI code should live in ios/shared/chrome (i.e. all code should be below ios/shared/chrome/browser/ui), so move WebStateList code to ios/chrome/browser/web_state_list. CL automated using tools/git/move_source_files.py and git cl format plus some editing to fix the name of the target in BUILD.gn files. BUG=None Review-Url: https://codereview.chromium.org/2806353002 Cr-Commit-Position: refs/heads/master@{#463271} Committed: https://chromium.googlesource.com/chromium/src/+/62a00bb9b11365ad84681fbadeddf2cb528dbc81

Patch Set 1 #

Patch Set 2 : Fix semantic conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -2759 lines) Patch
M ios/chrome/browser/metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder_web_state_list_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/snapshots/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_web_state_list_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_web_state_list_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_closing_web_state_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model_closing_web_state_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model_observers_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model_selected_tab_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_model_web_state_list_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_parenting_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox_perftest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ios/chrome/browser/web_state_list/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/fake_web_state_list_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/web_state_list/fake_web_state_list_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list.mm View 1 chunk +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_metrics_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_metrics_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_observer_bridge.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_order_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_order_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_order_controller_unittest.mm View 1 chunk +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_serialization.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_serialization.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm View 1 chunk +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_list_unittest.mm View 3 chunks +24 lines, -34 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_opener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_opener.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/web_state_list/web_state_opener_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/omnibox/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_collection/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_strip/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/web_contents/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/web_contents/web_contents_mediator.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/web_contents/web_contents_mediator_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
D ios/shared/chrome/browser/tabs/BUILD.gn View 1 chunk +0 lines, -68 lines 0 comments Download
D ios/shared/chrome/browser/tabs/fake_web_state_list_delegate.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/shared/chrome/browser/tabs/fake_web_state_list_delegate.mm View 1 chunk +0 lines, -17 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list.h View 1 chunk +0 lines, -162 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list.mm View 1 chunk +0 lines, -326 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper.mm View 1 chunk +0 lines, -147 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm View 1 chunk +0 lines, -101 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.mm View 1 chunk +0 lines, -73 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_observer.h View 1 chunk +0 lines, -74 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_observer.mm View 1 chunk +0 lines, -41 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_observer_bridge.h View 1 chunk +0 lines, -108 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_observer_bridge.mm View 1 chunk +0 lines, -116 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_order_controller.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_order_controller.mm View 1 chunk +0 lines, -90 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_order_controller_unittest.mm View 1 chunk +0 lines, -96 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_serialization.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_serialization.mm View 1 chunk +0 lines, -175 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_serialization_unittest.mm View 1 chunk +0 lines, -134 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_list_unittest.mm View 1 chunk +0 lines, -496 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_opener.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_opener.mm View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/shared/chrome/browser/tabs/web_state_opener_unittest.mm View 1 chunk +0 lines, -76 lines 0 comments Download
M ios/shared/chrome/browser/ui/browser_list/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/shared/chrome/browser/ui/browser_list/browser.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/shared/chrome/browser/ui/browser_list/browser_web_state_list_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
sdefresne
This is a reland of https://codereview.chromium.org/2799723002/. Patchset #1 is the original CL while patchset #2 ...
3 years, 8 months ago (2017-04-10 13:20:47 UTC) #2
rohitrao (ping after 24h)
lgtm Have you approved any other conflicting CLs today? =)
3 years, 8 months ago (2017-04-10 13:21:48 UTC) #5
rohitrao (ping after 24h)
Oh, can you remove the old commit position and review url from the cl description?
3 years, 8 months ago (2017-04-10 13:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806353002/20001
3 years, 8 months ago (2017-04-10 13:22:41 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:37:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/62a00bb9b11365ad84681fbadedd...

Powered by Google App Engine
This is Rietveld 408576698