Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2806343003: Revert of android: Async setupConnection binder call (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, danakj+watch_chromium.org, agrieve+watch_chromium.org, darin-cc_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Async setupConnection binder call (patchset #4 id:60001 of https://codereview.chromium.org/2810433002/ ) Reason for revert: Appears to have broken ChildProcessLauncherTest_testBindServiceFromMultipleProcesses/0 on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/41605 junit.framework.AssertionFailedError at org.chromium.content.browser.ChildProcessLauncherTest.testBindServiceFromMultipleProcesses(ChildProcessLauncherTest.java:448) at java.lang.reflect.Method.invokeNative(Native Method) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) Original issue's description: > android: Async setupConnection binder call > > Make setupConnection oneway/async. Add a ICallbackInt interface to > return the PID of the child process. The reply is then posted back to > launcher thread. Connection setup is already mostly async so only > involves moving related code to the reply callback. > > One caveat is that getCallingPid no longer works and just returns 0 > for oneway calls. The pid check is not strictly necessary, so dropped > the from setupConnection instead. > > BUG=689758, 690118 > > Review-Url: https://codereview.chromium.org/2810433002 > Cr-Commit-Position: refs/heads/master@{#463332} > Committed: https://chromium.googlesource.com/chromium/src/+/39c7bd71dc2f9c9f692dd346e4e4e525af25ede1 TBR=rsesek@chromium.org,jcivelli@chromium.org,torne@chromium.org,boliu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689758, 690118 Review-Url: https://codereview.chromium.org/2806343003 Cr-Commit-Position: refs/heads/master@{#463387} Committed: https://chromium.googlesource.com/chromium/src/+/2cc9e495637d506c65ae9802408043f7fbaf27d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -51 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D base/android/java/src/org/chromium/base/process_launcher/ICallbackInt.aidl View 1 chunk +0 lines, -9 lines 0 comments Download
M base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl View 1 chunk +2 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 2 chunks +12 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 4 chunks +8 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
please use gerrit instead
Created Revert of android: Async setupConnection binder call
3 years, 8 months ago (2017-04-10 20:51:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806343003/1
3 years, 8 months ago (2017-04-10 20:51:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2cc9e495637d506c65ae9802408043f7fbaf27d2
3 years, 8 months ago (2017-04-10 20:53:33 UTC) #6
boliu
3 years, 8 months ago (2017-04-10 21:02:31 UTC) #7
Message was sent while issue was closed.
On 2017/04/10 20:53:33, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/2cc9e495637d506c65ae98024080...

Ahh, already wrote fix waiting for review. I'll just re-open and reland then:
https://codereview.chromium.org/2810933002/

Powered by Google App Engine
This is Rietveld 408576698