Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2806313002: Ignore result from fwrite (Closed)

Created:
3 years, 8 months ago by landell
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Print error message if dumping wasm file fails BUG= Review-Url: https://codereview.chromium.org/2806313002 Cr-Commit-Position: refs/heads/master@{#45007} Committed: https://chromium.googlesource.com/v8/v8/+/d15687df02ea9a47bdc4755a0415419092f97f37

Patch Set 1 #

Patch Set 2 : Print message on error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/wasm/module-decoder.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
landell
@reviewer: PTAL. Small remove warning fix.
3 years, 8 months ago (2017-04-10 09:40:04 UTC) #3
landell
@reviewer: PTAL. Small remove warning fix.
3 years, 8 months ago (2017-04-10 09:40:05 UTC) #4
landell
On 2017/04/10 09:40:05, landell wrote: > @reviewer: PTAL. Small remove warning fix. Ping!
3 years, 8 months ago (2017-04-26 06:37:19 UTC) #6
Mircea Trofin
On 2017/04/26 06:37:19, landell wrote: > On 2017/04/10 09:40:05, landell wrote: > > @reviewer: PTAL. ...
3 years, 8 months ago (2017-04-26 14:16:56 UTC) #7
landell
On 2017/04/26 14:16:56, Mircea Trofin wrote: > On 2017/04/26 06:37:19, landell wrote: > > On ...
3 years, 7 months ago (2017-04-27 06:47:04 UTC) #8
Mircea Trofin
On 2017/04/27 06:47:04, landell wrote: > On 2017/04/26 14:16:56, Mircea Trofin wrote: > > On ...
3 years, 7 months ago (2017-04-27 15:21:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806313002/20001
3 years, 7 months ago (2017-05-02 07:44:24 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 08:12:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d15687df02ea9a47bdc4755a0415419092f...

Powered by Google App Engine
This is Rietveld 408576698