|
|
Chromium Code Reviews
DescriptionPrint error message if dumping wasm file fails
BUG=
Review-Url: https://codereview.chromium.org/2806313002
Cr-Commit-Position: refs/heads/master@{#45007}
Committed: https://chromium.googlesource.com/v8/v8/+/d15687df02ea9a47bdc4755a0415419092f97f37
Patch Set 1 #Patch Set 2 : Print message on error #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Ignore result from fwrite Shut up compiler warning BUG= ========== to ========== Ignore result from fwrite Shut up compiler warning BUG= ==========
landell@opera.com changed reviewers: + titzer@chromium.org
@reviewer: PTAL. Small remove warning fix.
@reviewer: PTAL. Small remove warning fix.
landell@opera.com changed reviewers: + mtrofin@google.com
On 2017/04/10 09:40:05, landell wrote: > @reviewer: PTAL. Small remove warning fix. Ping!
On 2017/04/26 06:37:19, landell wrote: > On 2017/04/10 09:40:05, landell wrote: > > @reviewer: PTAL. Small remove warning fix. > > Ping! Lgtm Alternatively, we could stdout on error?
On 2017/04/26 14:16:56, Mircea Trofin wrote: > On 2017/04/26 06:37:19, landell wrote: > > On 2017/04/10 09:40:05, landell wrote: > > > @reviewer: PTAL. Small remove warning fix. > > > > Ping! > > Lgtm > > Alternatively, we could stdout on error? Sure, is there a log macro I should use or just a regular printf?
On 2017/04/27 06:47:04, landell wrote: > On 2017/04/26 14:16:56, Mircea Trofin wrote: > > On 2017/04/26 06:37:19, landell wrote: > > > On 2017/04/10 09:40:05, landell wrote: > > > > @reviewer: PTAL. Small remove warning fix. > > > > > > Ping! > > > > Lgtm > > > > Alternatively, we could stdout on error? > > Sure, is there a log macro I should use or just a regular printf? I think we just use OFStream - like this: OFStream os(stderr); os << "Error while dumping wasm file" << std::endl; Oh - you were probably going to do that, but please also update the CL description to reflect this update.
Description was changed from ========== Ignore result from fwrite Shut up compiler warning BUG= ========== to ========== Print error message if dumping wasm file fails BUG= ==========
The CQ bit was checked by landell@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org Link to the patchset: https://codereview.chromium.org/2806313002/#ps20001 (title: "Print message on error")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493711055746240,
"parent_rev": "0740168409d8f8b494d907b07c1ead8cdf70e3e8", "commit_rev":
"d15687df02ea9a47bdc4755a0415419092f97f37"}
Message was sent while issue was closed.
Description was changed from ========== Print error message if dumping wasm file fails BUG= ========== to ========== Print error message if dumping wasm file fails BUG= Review-Url: https://codereview.chromium.org/2806313002 Cr-Commit-Position: refs/heads/master@{#45007} Committed: https://chromium.googlesource.com/v8/v8/+/d15687df02ea9a47bdc4755a0415419092f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/d15687df02ea9a47bdc4755a0415419092f... |
