Add //content/public/browser deps to //chrome/browser/ui/views

Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes chrome/browser/ui/tabs/tab_utils.h which includes content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit ugly of a solution.

BUG=711670
Review-Url: https://codereview.chromium.org/2806293004
Cr-Commit-Position: refs/heads/master@{#465051}
Committed: https://chromium.googlesource.com/chromium/src/+/487d548c3639002dbee792c672e0460da257bb17

[mattm, 2017-04-12 02:00:37]

Description was changed from

==========
Add //chrome/browser/ui deps to //chrome/browser/ui/views

BUG=none
==========

to

==========
Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes
chrome/browser/ui/tabs/tab_utils.h which includes
content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that
would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit
ugly of a solution.

BUG=none
==========

[mattm, 2017-04-12 03:13:49]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 03:14:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-12 03:28:39]

mattm@chromium.org changed reviewers:
+ brettw@chromium.org

[mattm, 2017-04-12 03:28:39]

Hi Brett,
Another deps issue. I see "gn help allow_circular_includes_from" has some
recommendations about creating a common deps target, but that looks like it'd be
a pretty big change. wdyt?

Sample failure (mac build with SDK 10.11):
In file included from ../../chrome/browser/ui/views/tabs/tab_renderer_data.cc:5:
In file included from ../../chrome/browser/ui/views/tabs/tab_renderer_data.h:9:
In file included from ../../chrome/browser/ui/tabs/tab_utils.h:13:
In file included from ../../content/public/browser/web_contents_user_data.h:10:
In file included from ../../content/public/browser/web_contents.h:21:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found
#include <openssl/opensslconf.h>

[commit-bot: I haz the power, 2017-04-12 04:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 04:08:03]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-14 18:43:28]

ping

[mattm, 2017-04-14 18:45:28]

Description was changed from

==========
Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes
chrome/browser/ui/tabs/tab_utils.h which includes
content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that
would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit
ugly of a solution.

BUG=none
==========

to

==========
Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes
chrome/browser/ui/tabs/tab_utils.h which includes
content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that
would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit
ugly of a solution.

BUG=711670
==========

[davidben, 2017-04-14 21:32:00]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2017-04-14 21:32:00]

CC svaldez since this is blocking https://codereview.chromium.org/2811393005/
(due to
https://boringssl.googlesource.com/boringssl/+/d403be92a436a45bd9be2e016cb250...
which should make this sort of thing easier to catch.)

[davidben, 2017-04-14 21:47:41]

davidben@chromium.org changed reviewers:
- davidben@chromium.org

[brettw, 2017-04-17 21:32:15]

lgtm

[mattm, 2017-04-17 21:43:18]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 22:56:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492465398662150,
"parent_rev": "b0aaaea26c58a1c0603d20a672b4a6765b9a7f99", "commit_rev":
"487d548c3639002dbee792c672e0460da257bb17"}

[commit-bot: I haz the power, 2017-04-17 22:56:52]

Description was changed from

==========
Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes
chrome/browser/ui/tabs/tab_utils.h which includes
content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that
would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit
ugly of a solution.

BUG=711670
==========

to

==========
Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes
chrome/browser/ui/tabs/tab_utils.h which includes
content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that
would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit
ugly of a solution.

BUG=711670

Review-Url: https://codereview.chromium.org/2806293004
Cr-Commit-Position: refs/heads/master@{#465051}
Committed:
https://chromium.googlesource.com/chromium/src/+/487d548c3639002dbee792c672e0...
==========

[commit-bot: I haz the power, 2017-04-17 22:56:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/487d548c3639002dbee792c672e0...