Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: ui/native_theme/native_theme_features.cc

Issue 2806263005: Convert the overlay scrollbar flag to use FeatureList (Closed)
Patch Set: dtapuska comment addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/native_theme/native_theme_features.cc
diff --git a/ui/native_theme/native_theme_features.cc b/ui/native_theme/native_theme_features.cc
new file mode 100644
index 0000000000000000000000000000000000000000..706654cc671b9a483fb2aa51ebabe5b6db37d62e
--- /dev/null
+++ b/ui/native_theme/native_theme_features.cc
@@ -0,0 +1,30 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/native_theme/native_theme_features.h"
+
+namespace features {
+
+#if defined(OS_ANDROID) || defined(OS_CHROMEOS)
dgozman 2017/04/13 17:33:28 I didn't find where this feature was enabled by de
chaopeng 2017/04/13 19:45:32 The CrOS enable by default is in here before. http
+const base::FeatureState kOverlayScrollbarFeatureState =
Peter Kasting 2017/04/13 18:28:15 Nit: Prefer constexpr to const for compile-time co
+ base::FEATURE_ENABLED_BY_DEFAULT;
+#else
+const base::FeatureState kOverlayScrollbarFeatureState =
+ base::FEATURE_DISABLED_BY_DEFAULT;
+#endif
+
+// Enables or disables overlay scrollbars in Blink (i.e. web content) on Aura
+// or Linux. The status of native UI overlay scrollbars are determined in
+// PlatformStyle::CreateScrollBar. Does nothing on Mac.
+const base::Feature kOverlayScrollbar{"OverlayScrollbar",
+ kOverlayScrollbarFeatureState};
+} // namespace features
Peter Kasting 2017/04/13 18:28:15 Nit: Blank line above?
+
+namespace ui {
+
+bool IsOverlayScrollbarEnabled() {
+ return base::FeatureList::IsEnabled(features::kOverlayScrollbar);
+}
+
+} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698