Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: ui/native_theme/native_theme_features.cc

Issue 2806263005: Convert the overlay scrollbar flag to use FeatureList (Closed)
Patch Set: dtapuska comment addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/native_theme/native_theme_features.h"
6
7 namespace features {
8
9 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
dgozman 2017/04/13 17:33:28 I didn't find where this feature was enabled by de
chaopeng 2017/04/13 19:45:32 The CrOS enable by default is in here before. http
10 const base::FeatureState kOverlayScrollbarFeatureState =
Peter Kasting 2017/04/13 18:28:15 Nit: Prefer constexpr to const for compile-time co
11 base::FEATURE_ENABLED_BY_DEFAULT;
12 #else
13 const base::FeatureState kOverlayScrollbarFeatureState =
14 base::FEATURE_DISABLED_BY_DEFAULT;
15 #endif
16
17 // Enables or disables overlay scrollbars in Blink (i.e. web content) on Aura
18 // or Linux. The status of native UI overlay scrollbars are determined in
19 // PlatformStyle::CreateScrollBar. Does nothing on Mac.
20 const base::Feature kOverlayScrollbar{"OverlayScrollbar",
21 kOverlayScrollbarFeatureState};
22 } // namespace features
Peter Kasting 2017/04/13 18:28:15 Nit: Blank line above?
23
24 namespace ui {
25
26 bool IsOverlayScrollbarEnabled() {
27 return base::FeatureList::IsEnabled(features::kOverlayScrollbar);
28 }
29
30 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698