Rename blink::AtomicString::Lower() to DeprecatedLower().

Rename blink::AtomicString::Lower() to DeprecatedLower().

Lower() is confusing, and is misused frequently.

BUG=627682
Review-Url: https://codereview.chromium.org/2806263002
Cr-Commit-Position: refs/heads/master@{#463237}
Committed: https://chromium.googlesource.com/chromium/src/+/599385089a2e09580b86528bad3814db9510ec1e

[tkent, 2017-04-10 07:14:10]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 07:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-04-10 08:15:39]

Description was changed from

==========
Rename blink::AtomicString::Lower() to DeprecatedLower().

BUG=627682
==========

to

==========
Rename blink::AtomicString::Lower() to DeprecatedLower().

Lower() is confusing, and is misused frequently.

BUG=627682
==========

[tkent, 2017-04-10 08:16:04]

tkent@chromium.org changed reviewers:
+ yutak@chromium.org

[tkent, 2017-04-10 08:16:05]

yutak@, would you review this please?

[tkent, 2017-04-10 08:27:00]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 08:27:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-04-10 08:34:09]

lgtm

https://codereview.chromium.org/2806263002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/text/AtomicString.h (right):

https://codereview.chromium.org/2806263002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/text/AtomicString.h:173: AtomicString
DeprecatedLower() const;
I would slightly prefer renaming this to LowerUnicode(), since there
could be a valid use case where you really want to transform
Unicode characters.

But yeah, it's kinda strange to have LowerUnicode in *Atomic*String,
given how AtomicStrings are used (symbols, IDs, etc.), so I'm okay
with DeprecatedLower(), too.

[tkent, 2017-04-10 08:45:22]

https://codereview.chromium.org/2806263002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/text/AtomicString.h (right):

https://codereview.chromium.org/2806263002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/text/AtomicString.h:173: AtomicString
DeprecatedLower() const;
On 2017/04/10 at 08:34:09, Yuta Kitamura wrote:
> I would slightly prefer renaming this to LowerUnicode(), since there
> could be a valid use case where you really want to transform
> Unicode characters.
> 
> But yeah, it's kinda strange to have LowerUnicode in *Atomic*String,
> given how AtomicStrings are used (symbols, IDs, etc.), so I'm okay
> with DeprecatedLower(), too.

IMO, we should apply the same approach to String too because if we renamed
Lower() to LowerUnicode() directly, we could not distinguish invalid usage of
Lower() and valid usage of Lower(). We should rename Lower() to
DeprecatedLower(), then should aim to remove it by replacing it to LowerASCII()
or LowerUnicode().

[commit-bot: I haz the power, 2017-04-10 09:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 09:58:18]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-10 12:49:14]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-04-10 12:49:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 12:55:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491828554440580,
"parent_rev": "f73af7b0dc19fe2ee514c6848c013388c1d6427a", "commit_rev":
"599385089a2e09580b86528bad3814db9510ec1e"}

[commit-bot: I haz the power, 2017-04-10 12:56:08]

Description was changed from

==========
Rename blink::AtomicString::Lower() to DeprecatedLower().

Lower() is confusing, and is misused frequently.

BUG=627682
==========

to

==========
Rename blink::AtomicString::Lower() to DeprecatedLower().

Lower() is confusing, and is misused frequently.

BUG=627682

Review-Url: https://codereview.chromium.org/2806263002
Cr-Commit-Position: refs/heads/master@{#463237}
Committed:
https://chromium.googlesource.com/chromium/src/+/599385089a2e09580b86528bad38...
==========

[commit-bot: I haz the power, 2017-04-10 12:56:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/599385089a2e09580b86528bad38...