Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2806233002: Add EXTERNAL_INTENT as a non-homescreen launch option. (Closed)

Created:
3 years, 8 months ago by dominickn
Modified:
3 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EXTERNAL_INTENT as a non-homescreen launch option. WebappInfo#isLaunchedFromHomescreen() should return false for WebAPKs launched from an external intent. BUG=691739 Review-Url: https://codereview.chromium.org/2806233002 Cr-Commit-Position: refs/heads/master@{#463424} Committed: https://chromium.googlesource.com/chromium/src/+/44c2c6431d328734d9507790eb8d1b9e08ece80e

Patch Set 1 : Add EXTERNAL_INTENT as a non-homescreen launch option. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
dominickn
PTAL, thanks!
3 years, 8 months ago (2017-04-10 06:38:11 UTC) #8
pkotwicz
lgtm
3 years, 8 months ago (2017-04-10 18:36:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806233002/20001
3 years, 8 months ago (2017-04-10 22:33:29 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:41:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44c2c6431d328734d9507790eb8d...

Powered by Google App Engine
This is Rietveld 408576698