Use FrameView rather than FrameViewBase for WebInputEventConversion

Use FrameView rather than FrameViewBase for WebInputEventConversion

WebMouseEventBuilder is only called from within WebPluginContainerImpl.
Currently the plugin is passed, but only the parent is used.
By passing the plugin parent, we can use FrameView type rather than
FrameViewBase.  This helps in removing the FrameViewBase/Widget class.

BUG=637460
Review-Url: https://codereview.chromium.org/2806223002
Cr-Commit-Position: refs/heads/master@{#463203}
Committed: https://chromium.googlesource.com/chromium/src/+/9bb7c0c57c6be13b19f47a289bafed94d55c3c45

[joelhockey, 2017-04-10 05:58:49]

Description was changed from

==========
Use FrameView rather than FrameViewBase for WebInputEventConversion

BUG=637460
==========

to

==========
Use FrameView rather than FrameViewBase for WebInputEventConversion

WebMouseEventBuilder is only called from within WebPluginContainerImpl.
Currently the plugin is passed, but only the parent is used.
By passing the plugin parent, we can use FrameView type rather than
FrameViewBase.  This helps in removing the FrameViewBase/Widget class.

BUG=637460
==========

[joelhockey, 2017-04-10 05:59:11]

joelhockey@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[haraken, 2017-04-10 06:45:59]

LGTM

[joelhockey, 2017-04-10 07:06:05]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 09:31:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491807965472450, "parent_rev":
"66ba5e7e910565510efe941cee9c1ba3c2db4f0e", "commit_rev":
"9bb7c0c57c6be13b19f47a289bafed94d55c3c45"}

[commit-bot: I haz the power, 2017-04-10 09:32:33]

Description was changed from

==========
Use FrameView rather than FrameViewBase for WebInputEventConversion

WebMouseEventBuilder is only called from within WebPluginContainerImpl.
Currently the plugin is passed, but only the parent is used.
By passing the plugin parent, we can use FrameView type rather than
FrameViewBase.  This helps in removing the FrameViewBase/Widget class.

BUG=637460
==========

to

==========
Use FrameView rather than FrameViewBase for WebInputEventConversion

WebMouseEventBuilder is only called from within WebPluginContainerImpl.
Currently the plugin is passed, but only the parent is used.
By passing the plugin parent, we can use FrameView type rather than
FrameViewBase.  This helps in removing the FrameViewBase/Widget class.

BUG=637460

Review-Url: https://codereview.chromium.org/2806223002
Cr-Commit-Position: refs/heads/master@{#463203}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bb7c0c57c6be13b19f47a289baf...
==========

[commit-bot: I haz the power, 2017-04-10 09:32:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bb7c0c57c6be13b19f47a289baf...

[dcheng, 2017-04-11 00:27:54]

dcheng@chromium.org changed reviewers:
+ kenrb@chromium.org

[dcheng, 2017-04-11 00:27:55]

https://codereview.chromium.org/2806223002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/2806223002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:96: // FIXME: Change
|FrameView| to const FrameView& after RemoteFrames get
+kenrb, is there some cleanup here?

https://codereview.chromium.org/2806223002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:99: const FrameView*
plugin_parent,
FWIW, I find this slightly confusing: there's nothing about this method that
seems particularly plugin specific. Maybe we need to add some more comments
somewhere or fix some names.

[haraken, 2017-04-11 01:07:24]

https://codereview.chromium.org/2806223002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/2806223002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:99: const FrameView*
plugin_parent,
On 2017/04/11 00:27:55, dcheng wrote:
> FWIW, I find this slightly confusing: there's nothing about this method that
> seems particularly plugin specific. Maybe we need to add some more comments
> somewhere or fix some names.

Yeah, this method itself is not doing anything plugin-specific. The method is
used only by plugin though.