Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2806203004: Reorder the Subresource filter setting to be under popups (Closed)

Created:
3 years, 8 months ago by Charlie Harrison
Modified:
3 years, 8 months ago
Reviewers:
Ted C, tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, agrieve+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, Finnur, emilyschechter
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder the Subresource filter setting to be under popups BUG=689487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2806203004 Cr-Commit-Position: refs/heads/master@{#463731} Committed: https://chromium.googlesource.com/chromium/src/+/94ad9a25b35bb0bb2fbb488c40239f5ece40b277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M chrome/android/java/res/xml/single_website_preferences.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/xml/site_settings_preferences.xml View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Charlie Harrison
tommycli: PTAL at site_settings_page.html tedchoc: PTAL at java/res/xml cc finnur, emilyschechter Please see the linked ...
3 years, 8 months ago (2017-04-11 18:17:39 UTC) #7
Ted C
On 2017/04/11 18:17:39, Charlie Harrison wrote: > tommycli: PTAL at site_settings_page.html > > tedchoc: PTAL ...
3 years, 8 months ago (2017-04-11 18:28:20 UTC) #8
tommycli
lgtm assuming the change has been approved by product, etc.
3 years, 8 months ago (2017-04-11 18:55:29 UTC) #9
Charlie Harrison
On 2017/04/11 18:55:29, tommycli wrote: > lgtm assuming the change has been approved by product, ...
3 years, 8 months ago (2017-04-11 19:09:53 UTC) #10
tommycli
On 2017/04/11 19:09:53, Charlie Harrison wrote: > On 2017/04/11 18:55:29, tommycli wrote: > > lgtm ...
3 years, 8 months ago (2017-04-11 19:16:07 UTC) #11
Charlie Harrison
Thanks, folks
3 years, 8 months ago (2017-04-11 19:17:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806203004/1
3 years, 8 months ago (2017-04-11 19:18:28 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 19:47:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94ad9a25b35bb0bb2fbb488c4023...

Powered by Google App Engine
This is Rietveld 408576698