Reorder the Subresource filter setting to be under popups

Reorder the Subresource filter setting to be under popups

BUG=689487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2806203004
Cr-Commit-Position: refs/heads/master@{#463731}
Committed: https://chromium.googlesource.com/chromium/src/+/94ad9a25b35bb0bb2fbb488c40239f5ece40b277

[Charlie Harrison, 2017-04-11 16:52:06]

Description was changed from

==========
Reorder the Subresource filter setting to be under popups

BUG=689487
==========

to

==========
Reorder the Subresource filter setting to be under popups

BUG=689487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Charlie Harrison, 2017-04-11 16:52:23]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 16:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 18:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:06:45]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2017-04-11 18:17:38]

csharrison@chromium.org changed reviewers:
+ tedchoc@chromium.org, tommycli@chromium.org

[Charlie Harrison, 2017-04-11 18:17:39]

tommycli: PTAL at site_settings_page.html

tedchoc: PTAL at java/res/xml

cc finnur, emilyschechter

Please see the linked bug for context around this reordering.

[Ted C, 2017-04-11 18:28:20]

On 2017/04/11 18:17:39, Charlie Harrison wrote:
> tommycli: PTAL at site_settings_page.html
> 
> tedchoc: PTAL at java/res/xml
> 
> cc finnur, emilyschechter
> 
> Please see the linked bug for context around this reordering.

lgtm

[tommycli, 2017-04-11 18:55:29]

lgtm assuming the change has been approved by product, etc.

[Charlie Harrison, 2017-04-11 19:09:53]

On 2017/04/11 18:55:29, tommycli wrote:
> lgtm assuming the change has been approved by product, etc.

Do you mean this particular reordering? I am just following emilyschechter's
advice on the linked bug.

The content setting and additional UI does not have launch approval yet, but we
are gating it behind a flag to frontload the engineering work.

[tommycli, 2017-04-11 19:16:07]

On 2017/04/11 19:09:53, Charlie Harrison wrote:
> On 2017/04/11 18:55:29, tommycli wrote:
> > lgtm assuming the change has been approved by product, etc.
> 
> Do you mean this particular reordering? I am just following emilyschechter's
> advice on the linked bug.
> 
> The content setting and additional UI does not have launch approval yet, but
we
> are gating it behind a flag to frontload the engineering work.

sounds good. lgtm

[Charlie Harrison, 2017-04-11 19:17:48]

Thanks, folks

[Charlie Harrison, 2017-04-11 19:17:53]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-04-11 19:18:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:46:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491938273285870, "parent_rev":
"8c4ef7b169a3306b4dd4935e1272e28aed80cabf", "commit_rev":
"94ad9a25b35bb0bb2fbb488c40239f5ece40b277"}

[commit-bot: I haz the power, 2017-04-11 19:47:35]

Description was changed from

==========
Reorder the Subresource filter setting to be under popups

BUG=689487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Reorder the Subresource filter setting to be under popups

BUG=689487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2806203004
Cr-Commit-Position: refs/heads/master@{#463731}
Committed:
https://chromium.googlesource.com/chromium/src/+/94ad9a25b35bb0bb2fbb488c4023...
==========

[commit-bot: I haz the power, 2017-04-11 19:47:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94ad9a25b35bb0bb2fbb488c4023...