Notify the remote suggestions scheduler when pulling up the Chrome Home sheet.

Notify the remote suggestions scheduler when pulling up the Chrome Home sheet.

When Chrome Home is disabled, opening a New Tab Page will notify the
scheduler to possibly trigger a soft fetch. With Chrome Home, pulling up
the bottom sheet takes the place of that.

BUG=709569
Review-Url: https://codereview.chromium.org/2806153005
Cr-Commit-Position: refs/heads/master@{#463471}
Committed: https://chromium.googlesource.com/chromium/src/+/13f16c6936f84a4bafa0770725b00b905440ebb3

[Bernhard Bauer, 2017-04-10 21:06:27]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:07:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-04-10 21:31:00]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:31:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 22:18:36]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-10 22:57:51]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2017-04-10 22:57:52]

Please review. Thanks!

[dgn, 2017-04-10 23:39:04]

lgtm

https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
(right):

https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java:124:
void onNtpInitialized();
I find it a bit icky that it's added to the suggestions source interface...
Definitely would be better with other schedule specific things, like
SnippetsBridge#fetchSuggestionsFromBackground. Maybe add a bug for this TODO so
that it doesn't go out of sight?

[Bernhard Bauer, 2017-04-10 23:54:54]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[Bernhard Bauer, 2017-04-10 23:54:59]

Thanks!

https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
(right):

https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java:124:
void onNtpInitialized();
On 2017/04/10 23:39:04, dgn (in PST timezone) wrote:
> I find it a bit icky that it's added to the suggestions source interface...
> Definitely would be better with other schedule specific things, like
> SnippetsBridge#fetchSuggestionsFromBackground. Maybe add a bug for this TODO
so
> that it doesn't go out of sight?

Done.

[Bernhard Bauer, 2017-04-10 23:55:06]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2017-04-10 23:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org
Link to the patchset: https://codereview.chromium.org/2806153005/#ps40001
(title: "add bug")

[commit-bot: I haz the power, 2017-04-10 23:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 00:45:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491868506714870,
"parent_rev": "dba8a17e64a4d6bc35e941b2b2a46003c25c5505", "commit_rev":
"13f16c6936f84a4bafa0770725b00b905440ebb3"}

[commit-bot: I haz the power, 2017-04-11 00:46:30]

Description was changed from

==========
Notify the remote suggestions scheduler when pulling up the Chrome Home sheet.

When Chrome Home is disabled, opening a New Tab Page will notify the
scheduler to possibly trigger a soft fetch. With Chrome Home, pulling up
the bottom sheet takes the place of that.

BUG=709569
==========

to

==========
Notify the remote suggestions scheduler when pulling up the Chrome Home sheet.

When Chrome Home is disabled, opening a New Tab Page will notify the
scheduler to possibly trigger a soft fetch. With Chrome Home, pulling up
the bottom sheet takes the place of that.

BUG=709569

Review-Url: https://codereview.chromium.org/2806153005
Cr-Commit-Position: refs/heads/master@{#463471}
Committed:
https://chromium.googlesource.com/chromium/src/+/13f16c6936f84a4bafa0770725b0...
==========

[commit-bot: I haz the power, 2017-04-11 00:46:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13f16c6936f84a4bafa0770725b0...

[jkrcal, 2017-04-11 05:29:43]

jkrcal@chromium.org changed reviewers:
+ jkrcal@chromium.org

[jkrcal, 2017-04-11 05:29:44]

https://codereview.chromium.org/2806153005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
(right):

https://codereview.chromium.org/2806153005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java:89:
suggestionsSource.onNtpInitialized();
Does this line mean that the signal is sent also initially when the browser gets
started and the bottom sheet is created? (sgtm, just want to understand)