Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2806153005: Notify the remote suggestions scheduler when pulling up the Chrome Home sheet. (Closed)

Created:
3 years, 8 months ago by Bernhard Bauer
Modified:
3 years, 8 months ago
Reviewers:
jkrcal, dgn
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org, jkrcal
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify the remote suggestions scheduler when pulling up the Chrome Home sheet. When Chrome Home is disabled, opening a New Tab Page will notify the scheduler to possibly trigger a soft fetch. With Chrome Home, pulling up the bottom sheet takes the place of that. BUG=709569 Review-Url: https://codereview.chromium.org/2806153005 Cr-Commit-Position: refs/heads/master@{#463471} Committed: https://chromium.googlesource.com/chromium/src/+/13f16c6936f84a4bafa0770725b00b905440ebb3

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : add bug #

Total comments: 1

Messages

Total messages: 19 (13 generated)
Bernhard Bauer
Please review. Thanks!
3 years, 8 months ago (2017-04-10 22:57:52 UTC) #8
dgn
lgtm https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java (right): https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java#newcode124 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java:124: void onNtpInitialized(); I find it a bit icky ...
3 years, 8 months ago (2017-04-10 23:39:04 UTC) #9
Bernhard Bauer
Thanks! https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java (right): https://codereview.chromium.org/2806153005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java#newcode124 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java:124: void onNtpInitialized(); On 2017/04/10 23:39:04, dgn (in PST ...
3 years, 8 months ago (2017-04-10 23:54:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806153005/40001
3 years, 8 months ago (2017-04-10 23:55:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/13f16c6936f84a4bafa0770725b00b905440ebb3
3 years, 8 months ago (2017-04-11 00:46:31 UTC) #17
jkrcal
3 years, 8 months ago (2017-04-11 05:29:44 UTC) #19
Message was sent while issue was closed.
https://codereview.chromium.org/2806153005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
(right):

https://codereview.chromium.org/2806153005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java:89:
suggestionsSource.onNtpInitialized();
Does this line mean that the signal is sent also initially when the browser gets
started and the bottom sheet is created? (sgtm, just want to understand)

Powered by Google App Engine
This is Rietveld 408576698