Issue 280613002: Pepper: Remove unnecessary CloseManifestEntry code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280613002: Pepper: Remove unnecessary CloseManifestEntry code. (Closed)

Created:
6 years, 7 months ago by teravest

Modified:
6 years, 7 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Remove unnecessary CloseManifestEntry code. There's some logic in ServiceRuntime to support a future implementation for CloseManifestEntry, but since we don't take any useful action, it's much simpler to always return true. This makes ServiceRuntime even smaller. This also removes an unused struct in ServiceRuntime. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269962

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Also remove QuotaRequest #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -77 lines)			Patch
	M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View	1 2	2 chunks	+0 lines, -38 lines	0 comments	Download
	M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		1 chunk	+3 lines, -39 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/280613002/40001

6 years, 7 months ago (2014-05-12 20:02:52 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-12 20:37:51 UTC) #5

Message was sent while issue was closed.

Change committed as 269962

Expand Messages | Collapse Messages