Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 280613002: Pepper: Remove unnecessary CloseManifestEntry code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also remove QuotaRequest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/service_runtime.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc
diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
index 96d63354aee5354a898b00e745c15f80f13c19d0..9b4d3f56dcdffa1e3667556bed422a2862828c4b 100644
--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc
+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
@@ -452,45 +452,9 @@ void PluginReverseInterface::StreamAsFile_MainThreadContinuation(
}
bool PluginReverseInterface::CloseManifestEntry(int32_t desc) {
- bool op_complete = false;
- bool op_result;
- CloseManifestEntryResource* to_close =
- new CloseManifestEntryResource(desc, &op_complete, &op_result);
-
- plugin::WeakRefCallOnMainThread(
- anchor_,
- 0,
- this,
- &plugin::PluginReverseInterface::
- CloseManifestEntry_MainThreadContinuation,
- to_close);
-
- // wait for completion or surf-away.
- {
- nacl::MutexLocker take(&mu_);
- while (!shutting_down_ && !op_complete)
- NaClXCondVarWait(&cv_, &mu_);
- if (shutting_down_)
- return false;
- }
-
- // op_result true if close was successful; false otherwise (e.g., bad desc).
- return op_result;
-}
-
-void PluginReverseInterface::CloseManifestEntry_MainThreadContinuation(
- CloseManifestEntryResource* cls,
- int32_t err) {
- UNREFERENCED_PARAMETER(err);
-
- nacl::MutexLocker take(&mu_);
- // TODO(bsy): once the plugin has a reliable way to report that the
- // file usage is done -- and sel_ldr uses this RPC call -- we should
- // tell the plugin that the associated resources can be freed.
- *cls->op_result_ptr = true;
- *cls->op_complete_ptr = true;
- NaClXCondVarBroadcast(&cv_);
- // cls automatically deleted
+ // We don't take any action on a call to CloseManifestEntry today, so always
+ // return success.
+ return true;
}
void PluginReverseInterface::ReportCrash() {
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/service_runtime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698