Restore behaviour of middle anonymous blocks inheriting style from inline parents

Restore behaviour of middle anonymous blocks inheriting style from inline parents

BUG=706324
Review-Url: https://codereview.chromium.org/2806123002
Cr-Commit-Position: refs/heads/master@{#465729}
Committed: https://chromium.googlesource.com/chromium/src/+/4cd4d67ff4b29899a150e92a129179ca4bbcdd49

[rhogan, 2017-04-09 12:32:37]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 12:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 12:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 12:34:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rhogan, 2017-04-09 13:08:23]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 13:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 14:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 14:27:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rhogan, 2017-04-10 15:36:18]

robhogan@gmail.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2017-04-19 09:32:49]

Looking good!

I don't really have any strong opinions as to whether letting the anonymous
block inherit from the inline (this CL), or let it inherit from the containing
block of the inline (which is what https://codereview.chromium.org/2792643002/
proposes). The bottom line here is that the anonymous block shouldn't even
exist. That means that we have to make sure that it's not web-exposed in any
way.

What matters is that this piece of weirdness is well documented and has a test,
so let's continue with this CL. I'll close the other one.

https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/inline/middle-continuation-inherits-visibility-from-inline-parent.html
(right):

https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/inline/middle-continuation-inherits-visibility-from-inline-parent.html:5:
width:100px;
width and height don't apply to inline, so these are unnecessary declarations.

Specifying background-color doesn't seem to make a lot of sense either, since
the A is essentially empty, and backgrounds are not inherited.

https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/inline/middle-continuation-inherits-visibility-from-inline-parent.html:21:
testRunner.dumpAsText();
Could you rewrite this as a testharness test? Then we won't need the
-expected.txt counterpart.

https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutInline.cpp:357: // formatting
context of its own, removing the need for continuations.
Great comment. Could you also add that this anonymous block doesn't exist in the
spec, and that that's the reason why we have to make sure that it has absolutely
no effect?

[rhogan, 2017-04-19 18:42:07]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 18:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-04-19 18:42:58]

On 2017/04/19 at 09:32:49, mstensho wrote:
>
https://codereview.chromium.org/2806123002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutInline.cpp:357: // formatting
context of its own, removing the need for continuations.
> Great comment. Could you also add that this anonymous block doesn't exist in
the spec, and that that's the reason why we have to make sure that it has
absolutely no effect?

Thanks for that Martin - applied your comments, so ready for another look.

[mstensho (USE GERRIT), 2017-04-19 19:26:22]

lgtm

[rhogan, 2017-04-19 20:02:52]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2017-04-19 20:02:56]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2017-04-19 20:03:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 20:20:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492632176443070,
"parent_rev": "647872c5ada49e2c4a7985fcca5c4a93c5bb1760", "commit_rev":
"4cd4d67ff4b29899a150e92a129179ca4bbcdd49"}

[commit-bot: I haz the power, 2017-04-19 20:21:11]

Description was changed from

==========
Restore behaviour of middle anonymous blocks inheriting style from inline
parents

BUG=706324
==========

to

==========
Restore behaviour of middle anonymous blocks inheriting style from inline
parents

BUG=706324

Review-Url: https://codereview.chromium.org/2806123002
Cr-Commit-Position: refs/heads/master@{#465729}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cd4d67ff4b29899a150e92a1291...
==========

[commit-bot: I haz the power, 2017-04-19 20:21:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4cd4d67ff4b29899a150e92a1291...