Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2806083002: Remove PrintMsg_PrintPage_Params. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, mac-reviews_chromium.org, jzfeng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PrintMsg_PrintPage_Params. It is not being used in any IPC messages. Review-Url: https://codereview.chromium.org/2806083002 Cr-Commit-Position: refs/heads/master@{#463340} Committed: https://chromium.googlesource.com/chromium/src/+/6a2e532fb7af06163a093c04ac94b2b5b4db1e16

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -61 lines) Patch
M components/printing/common/print_messages.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 6 chunks +21 lines, -26 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_linux.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_mac.mm View 1 1 chunk +8 lines, -11 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_pdf_win.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Lei Zhang
While reviewing jzfeng's earlier CL, I came to realize PrintMsg_PrintPage_Params is pointless. It's not even ...
3 years, 8 months ago (2017-04-08 04:29:03 UTC) #6
Tom Sepez
lgtm
3 years, 8 months ago (2017-04-10 15:52:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806083002/1
3 years, 8 months ago (2017-04-10 17:34:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/72637) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 17:38:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806083002/20001
3 years, 8 months ago (2017-04-10 17:46:58 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:39:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6a2e532fb7af06163a093c04ac94...

Powered by Google App Engine
This is Rietveld 408576698