Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2806033003: blink_rename_merge_helper: package clang includes as well. (Closed)

Created:
3 years, 8 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_rename_merge_helper: package clang includes as well. Without this, the clang tool will complain about missing headers from the standard library. On Mac, this includes libc++ as well. BUG=676588 R=lukasza@chromium.org Review-Url: https://codereview.chromium.org/2806033003 . Cr-Commit-Position: refs/heads/master@{#463073} Committed: https://chromium.googlesource.com/chromium/src/+/9294c4d4bf42d0b3658be583b0603f1cf3715009

Patch Set 1 #

Patch Set 2 : Strip out unneeded libs #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/blink_rename_merge_helper/COMPONENTS View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
3 years, 8 months ago (2017-04-07 23:56:23 UTC) #2
Łukasz Anforowicz
LGTM
3 years, 8 months ago (2017-04-08 00:01:16 UTC) #3
dcheng
3 years, 8 months ago (2017-04-08 00:32:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9294c4d4bf42d0b3658be583b0603f1cf3715009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698