Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2806023003: Remove vestigial Context arguments in ExternalAuthUtils, part 3/3 (Closed)

Created:
3 years, 8 months ago by paulmiller
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org, Peter Wen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vestigial Context arguments in ExternalAuthUtils, part 3/3 BUG=709208 Review-Url: https://codereview.chromium.org/2806023003 Cr-Commit-Position: refs/heads/master@{#463034} Committed: https://chromium.googlesource.com/chromium/src/+/fd8989730fde1248659628b9a36d74ab421e0040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 3 chunks +2 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gcore/ChromeGoogleApiClientImpl.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
paulmiller
On 2017/04/07 22:08:38, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:mariakhomenko@chromium.org PTAL
3 years, 8 months ago (2017-04-07 22:09:04 UTC) #3
Maria
lgtm
3 years, 8 months ago (2017-04-07 22:12:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806023003/1
3 years, 8 months ago (2017-04-07 22:16:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/405980)
3 years, 8 months ago (2017-04-07 22:25:23 UTC) #8
paulmiller
On 2017/04/07 22:25:23, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-07 22:39:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806023003/1
3 years, 8 months ago (2017-04-07 22:40:33 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:06:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd8989730fde1248659628b9a36d...

Powered by Google App Engine
This is Rietveld 408576698