Adding session object for iOS to integerate client sessions.

Adding session object for iOS to integerate client sessions.

Not finished implementing yet, but this will be the iOS version of remoting
client that ties the remoting/client common session to iOS.

BUG=652781
Review-Url: https://codereview.chromium.org/2805963002
Cr-Commit-Position: refs/heads/master@{#463337}
Committed: https://chromium.googlesource.com/chromium/src/+/4e433f99b03ba6fd056ac1b8bbc1edd8db95d94a

[nicholss, 2017-04-07 18:32:33]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[nicholss, 2017-04-07 18:33:52]

nicholss@chromium.org changed reviewers:
+ yuweih@chromium.org

[nicholss, 2017-04-07 18:33:53]

PTAL, thanks!

[commit-bot: I haz the power, 2017-04-07 18:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:48:36]

Dry run: This issue passed the CQ dry run.

[nicholss, 2017-04-07 21:38:24]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:39:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:50:58]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2017-04-08 02:42:37]

LGTM

I'm not very familiar with ObjC and you may need an OWNER approval O_o

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/dis...
File remoting/client/ios/display/gl_display_handler.mm (right):

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/dis...
remoting/client/ios/display/gl_display_handler.mm:125: // demo_screen_
What are these comments for?

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/ses...
File remoting/client/ios/session/remoting_client.mm (right):

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/ses...
remoting/client/ios/session/remoting_client.mm:45: NSLog(@"TODO(nicholss):
Implement the FetchSecretCallback.");
Just curious why do you log out the TODO rather than writing it as a comment
O_o? Also why using NSLog instead of the LOG(level) macros?

[nicholss, 2017-04-10 16:17:09]

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/dis...
File remoting/client/ios/display/gl_display_handler.mm (right):

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/dis...
remoting/client/ios/display/gl_display_handler.mm:125: // demo_screen_
Cruft leftover from playing with the demo. I will remove this when the demo code
is removed.

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/ses...
File remoting/client/ios/session/remoting_client.mm (right):

https://codereview.chromium.org/2805963002/diff/20001/remoting/client/ios/ses...
remoting/client/ios/session/remoting_client.mm:45: NSLog(@"TODO(nicholss):
Implement the FetchSecretCallback.");
On 2017/04/08 02:42:37, Yuwei wrote:
> Just curious why do you log out the TODO rather than writing it as a comment
> O_o? Also why using NSLog instead of the LOG(level) macros?

I wanted the TODO in the logs while I am working on the app so I can remember
there are sections of code that need to be worked on still. I picked up the tip
from another team. I could use LOG but I figured NSLog was ok for this because
it will be replaced before the application is allowed to be called finished.
Just a comment TODO might not remind you that a flow in your application is
missing.

[nicholss, 2017-04-10 16:17:18]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:26:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nicholss, 2017-04-10 17:55:22]

nicholss@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[nicholss, 2017-04-10 17:55:23]

Need an owner to review. +jamiewalch

[Jamie, 2017-04-10 18:11:11]

lgtm

[nicholss, 2017-04-10 18:16:01]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:16:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:31:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491848161576360,
"parent_rev": "5f60fb4d0d4527442621b0626edac9ca97a27fa2", "commit_rev":
"4e433f99b03ba6fd056ac1b8bbc1edd8db95d94a"}

[commit-bot: I haz the power, 2017-04-10 18:31:49]

Description was changed from

==========
Adding session object for iOS to integerate client sessions.

Not finished implementing yet, but this will be the iOS version of remoting
client that ties the remoting/client common session to iOS.

BUG=652781
==========

to

==========
Adding session object for iOS to integerate client sessions.

Not finished implementing yet, but this will be the iOS version of remoting
client that ties the remoting/client common session to iOS.

BUG=652781

Review-Url: https://codereview.chromium.org/2805963002
Cr-Commit-Position: refs/heads/master@{#463337}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e433f99b03ba6fd056ac1b8bbc1...
==========

[commit-bot: I haz the power, 2017-04-10 18:31:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e433f99b03ba6fd056ac1b8bbc1...