Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2805923002: Enable settings hardening on OSX when no Finch config is present (Closed)

Created:
3 years, 8 months ago by proberge
Modified:
3 years, 8 months ago
Reviewers:
gab, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable settings hardening on OSX when no Finch config is present BUG=500085 Review-Url: https://codereview.chromium.org/2805923002 Cr-Commit-Position: refs/heads/master@{#463313} Committed: https://chromium.googlesource.com/chromium/src/+/2562e6f3cf64e1eb1ae95098fa46e626a4494cb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
proberge
3 years, 8 months ago (2017-04-10 13:42:46 UTC) #7
gab
lgtm
3 years, 8 months ago (2017-04-10 16:24:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805923002/1
3 years, 8 months ago (2017-04-10 16:55:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/406908)
3 years, 8 months ago (2017-04-10 17:04:48 UTC) #12
proberge
@Devlin can you review the changes to extension_startup_browsertest.cc ? Thanks!
3 years, 8 months ago (2017-04-10 17:17:41 UTC) #14
Devlin
extensions lgtm
3 years, 8 months ago (2017-04-10 17:21:41 UTC) #15
proberge
Thanks for the quick review :)
3 years, 8 months ago (2017-04-10 17:22:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805923002/1
3 years, 8 months ago (2017-04-10 17:22:40 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:47:51 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2562e6f3cf64e1eb1ae95098fa46...

Powered by Google App Engine
This is Rietveld 408576698