Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2805903003: Fix crash in RequestSenderTest.RequestSendSuccess. (Closed)

Created:
3 years, 8 months ago by Sorin Jianu
Modified:
3 years, 8 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in RequestSenderTest.RequestSendSuccess. [ RUN ] RequestSenderTest.RequestSendSuccess [54568:29108:0407/114750.146:3888807750:FATAL:url_request_filter.cc(54)] Check failed: 0u == hostname_interceptor_map_.count(make_pair(scheme, hostname)) (0 vs. 1) After enabling PingManagerTest, the subsequent RequestSenderTest may fail because the PingManagerTest does not unregister its interceptors correctly. TBR=waffles@chromium.org BUG=349547 Review-Url: https://codereview.chromium.org/2805903003 Cr-Commit-Position: refs/heads/master@{#462981} Committed: https://chromium.googlesource.com/chromium/src/+/610c1e208e8eeca0206000a3c5d58b3b49f523c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/update_client/ping_manager_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805903003/1
3 years, 8 months ago (2017-04-07 20:08:33 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:17:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/610c1e208e8eeca0206000a3c5d5...

Powered by Google App Engine
This is Rietveld 408576698