Fix races in MediaStream video constraints tests.

Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the constructor to avoid races.

BUG=709112
TBR=hbos@chromium.org

Review-Url: https://codereview.chromium.org/2805903002
Cr-Commit-Position: refs/heads/master@{#462928}
Committed: https://chromium.googlesource.com/chromium/src/+/cf4aa356378e931692ed10abbe78d2fddbca60b2

[Guido Urdaneta, 2017-04-07 17:19:44]

Description was changed from

==========
Fix races in MediaStream video constraints tests.

The tests raced because they were changing a global flag in parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects that set the flag in their constructor to avoid
races.

BUG=709112
==========

to

==========
Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in
parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the
constructor to avoid races.

BUG=709112
==========

[Guido Urdaneta, 2017-04-07 17:21:10]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-04-07 17:22:23]

guidou@chromium.org changed reviewers:
+ ellyjones@chromium.org, hbos@chromium.org

[Guido Urdaneta, 2017-04-07 17:25:05]

Hi, PTAL

[Guido Urdaneta, 2017-04-07 17:29:57]

Description was changed from

==========
Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in
parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the
constructor to avoid races.

BUG=709112
==========

to

==========
Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in
parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the
constructor to avoid races.

BUG=709112
TBR=hbos@chromium.org
==========

[Guido Urdaneta, 2017-04-07 17:30:17]

The CQ bit was unchecked by guidou@chromium.org

[Guido Urdaneta, 2017-04-07 17:30:25]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:31:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:19:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491586225560360, "parent_rev":
"931d158f73d21b37bad43543239a7da2f587ff0e", "commit_rev":
"cf4aa356378e931692ed10abbe78d2fddbca60b2"}

[commit-bot: I haz the power, 2017-04-07 18:20:30]

Description was changed from

==========
Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in
parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the
constructor to avoid races.

BUG=709112
TBR=hbos@chromium.org
==========

to

==========
Fix races in MediaStream video constraints tests.

The tests raced because each test case was changing a global flag potentially in
parallel.
Instead of having separate test cases that each set the flag, have
separate tests objects for each value of the flag, and set the flag in the
constructor to avoid races.

BUG=709112
TBR=hbos@chromium.org

Review-Url: https://codereview.chromium.org/2805903002
Cr-Commit-Position: refs/heads/master@{#462928}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf4aa356378e931692ed10abbe78...
==========

[commit-bot: I haz the power, 2017-04-07 18:20:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf4aa356378e931692ed10abbe78...