Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2805873002: Make the answers text color more consistent. (Closed)

Created:
3 years, 8 months ago by Justin Donnelly
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the answers text color more consistent. All answer text (other than the suggestion text and positive/negative text) is now the de-emphasizing gray. BUG=709101 Review-Url: https://codereview.chromium.org/2805873002 Cr-Commit-Position: refs/heads/master@{#463275} Committed: https://chromium.googlesource.com/chromium/src/+/89669caf0861ddd3a08e3c474989de65cf6caff9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Justin Donnelly
3 years, 8 months ago (2017-04-07 15:39:28 UTC) #4
Justin Donnelly
Friendly ping. If this looks good to you, can you hit the submit for me?
3 years, 8 months ago (2017-04-10 02:57:26 UTC) #7
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-10 12:36:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805873002/1
3 years, 8 months ago (2017-04-10 15:27:35 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:43:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89669caf0861ddd3a08e3c474989...

Powered by Google App Engine
This is Rietveld 408576698