Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2805793004: Re-enable css-grid-1 tests from WPT repository (Closed)

Created:
3 years, 8 months ago by Manuel Rego
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable css-grid-1 tests from WPT repository BUG=706118 Review-Url: https://codereview.chromium.org/2805793004 Cr-Commit-Position: refs/heads/master@{#462817} Committed: https://chromium.googlesource.com/chromium/src/+/584e736deb93c5c8a7b5c79dfcdfd1ec97f135d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Manuel Rego
Let's bring the tests back! Following a similar pattern than in this CL: https://codereview.chromium.org/2802063002
3 years, 8 months ago (2017-04-07 08:26:36 UTC) #2
jfernandez
lgtm
3 years, 8 months ago (2017-04-07 08:35:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805793004/1
3 years, 8 months ago (2017-04-07 08:40:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 09:24:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/584e736deb93c5c8a7b5c79dfcdf...

Powered by Google App Engine
This is Rietveld 408576698