Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2805793003: Add user-agent flag to headless (Closed)

Created:
3 years, 8 months ago by irisu
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add user-agent flag to headless BUG=604324 Review-Url: https://codereview.chromium.org/2805793003 Cr-Commit-Position: refs/heads/master@{#463221} Committed: https://chromium.googlesource.com/chromium/src/+/6de4c9216f701b9e0e075bff999350853a9c5a74

Patch Set 1 #

Patch Set 2 : Add shell switches to build file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M headless/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M headless/app/headless_shell.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_content_browser_client.cc View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
irisu
3 years, 8 months ago (2017-04-07 06:05:14 UTC) #2
Sami
lgtm, thanks! Sorry for the back-and-forth about this.
3 years, 8 months ago (2017-04-07 09:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805793003/1
3 years, 8 months ago (2017-04-10 00:59:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/272708)
3 years, 8 months ago (2017-04-10 01:11:58 UTC) #7
irisu
On 2017/04/10 01:11:58, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-10 02:28:49 UTC) #8
Sami
Still lgtm.
3 years, 8 months ago (2017-04-10 10:19:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805793003/20001
3 years, 8 months ago (2017-04-10 10:20:46 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 11:29:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6de4c9216f701b9e0e075bff9993...

Powered by Google App Engine
This is Rietveld 408576698