Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2805783003: [csa] Fix CSA::ToUint32 rounding for negative HeapNumbers (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Fix CSA::ToUint32 rounding for negative HeapNumbers The spec requires truncation while ToUint32 originally rounded down. This also adds a bunch of test cases to check edge case behavior. BUG=v8:6212 Review-Url: https://codereview.chromium.org/2805783003 Cr-Commit-Position: refs/heads/master@{#44487} Committed: https://chromium.googlesource.com/v8/v8/+/52a53da5a4ee252ce47b9c396047610901a446cf

Patch Set 1 #

Patch Set 2 : Comment formatting #

Patch Set 3 : Fix Smi::IsValid test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 2 2 chunks +105 lines, -0 lines 0 comments Download
M test/mjsunit/string-split.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
jgruber
3 years, 8 months ago (2017-04-07 11:37:21 UTC) #6
Jakob Kummerow
lgtm
3 years, 8 months ago (2017-04-07 12:05:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805783003/40001
3 years, 8 months ago (2017-04-07 12:46:21 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:50:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/52a53da5a4ee252ce47b9c396047610901a...

Powered by Google App Engine
This is Rietveld 408576698