Implement ownProperty() and inheritFrom() assertions in should()

Implement ownProperty() and inheritFrom() assertions in should()

This CL add two assertions that abstracts the checks for JavaScript
traits.

 - should().ownProperty()
 - should().inheritFrom()

BUG=702708
TEST=webaudio/unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2805773002
Cr-Commit-Position: refs/heads/master@{#462970}
Committed: https://chromium.googlesource.com/chromium/src/+/b7faac578f403d2a6bb4a767578661079cbf5963

[hongchan, 2017-04-06 22:59:25]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-04-06 22:59:26]

PTAL.

[Raymond Toy, 2017-04-06 23:13:14]

Some nits.

Possible also consider rewriting audio-scheduled-source-basic.html to use these
new methods.

resources/context-properties.js checks properties too.

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:979: ownProperty() {
ownProperty or beOwnPropertyOf (as mentioned in the bug)?

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html:44:
should(sourceNode, 'A BufferSourceNode')
There's no such thing as a BufferSourceNode, so use AudioBufferSourceNode in the
description.

[hongchan, 2017-04-07 15:55:37]

I took a look at context-properties.js and it's already using
getOwnPropertyNames() inside. Check the populated result with hasOwnProperty()
seems to be meaningless.

If you still think we should rewrite the test, it needs to be rewritten from
scratch by only using new assertions in another CL.

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:979: ownProperty() {
On 2017/04/06 23:13:14, Raymond Toy wrote:
> ownProperty or beOwnPropertyOf (as mentioned in the bug)?

I think this is cleaner. Let me know if you think otherwise. (You're the primary
customer!)

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html:44:
should(sourceNode, 'A BufferSourceNode')
On 2017/04/06 23:13:14, Raymond Toy wrote:
> There's no such thing as a BufferSourceNode, so use AudioBufferSourceNode in
the
> description.

Done.

[Raymond Toy, 2017-04-07 16:10:58]

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:979: ownProperty() {
On 2017/04/07 15:55:36, hongchan wrote:
> On 2017/04/06 23:13:14, Raymond Toy wrote:
> > ownProperty or beOwnPropertyOf (as mentioned in the bug)?
> 
> I think this is cleaner. Let me know if you think otherwise. (You're the
primary
> customer!)

Maybe

should(obj).haveOwnProperty(property)

?  beOwnPropertyOf is backwards.

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
(right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html:39:
should(AudioScheduledSourceNode.prototype,
It's nicer if it were

should(AudioScheduledSourceNode, '...').ownProperty(<property>)

but maybe that's bad style. (Passing in object instead of object.prototype).

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:1005: '${actual} does
not have an own own property of "${expected}".',
"own own"?

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
(right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt:40: PASS  
BaseAudioContext.prototype does not have an own own property of
"startRendering".
Typo: "own own"

[hongchan, 2017-04-07 17:22:17]

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:979: ownProperty() {
On 2017/04/07 16:10:58, Raymond Toy wrote:
> On 2017/04/07 15:55:36, hongchan wrote:
> > On 2017/04/06 23:13:14, Raymond Toy wrote:
> > > ownProperty or beOwnPropertyOf (as mentioned in the bug)?
> > 
> > I think this is cleaner. Let me know if you think otherwise. (You're the
> primary
> > customer!)
> 
> Maybe
> 
> should(obj).haveOwnProperty(property)
> 
> ?  beOwnPropertyOf is backwards.

I llke haveOwnProperty().

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
(right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html:39:
should(AudioScheduledSourceNode.prototype,
On 2017/04/07 16:10:58, Raymond Toy wrote:
> It's nicer if it were
> 
> should(AudioScheduledSourceNode, '...').ownProperty(<property>)
> 
> but maybe that's bad style. (Passing in object instead of object.prototype).

What if we want to check an object not the prototype? :)

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:1005: '${actual} does
not have an own own property of "${expected}".',
On 2017/04/07 16:10:58, Raymond Toy wrote:
> "own own"?

Oops.

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
(right):

https://codereview.chromium.org/2805773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt:40: PASS  
BaseAudioContext.prototype does not have an own own property of
"startRendering".
On 2017/04/07 16:10:58, Raymond Toy wrote:
> Typo: "own own"

Done.

[Raymond Toy, 2017-04-07 18:20:54]

lgtm

[hongchan, 2017-04-07 18:33:52]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:34:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:48:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491590032915940,
"parent_rev": "958c1c976cd22ec4ed8e5695351ea3868b096961", "commit_rev":
"b7faac578f403d2a6bb4a767578661079cbf5963"}

[commit-bot: I haz the power, 2017-04-07 19:49:00]

Description was changed from

==========
Implement ownProperty() and inheritFrom() assertions in should()

This CL add two assertions that abstracts the checks for JavaScript
traits.

 - should().ownProperty()
 - should().inheritFrom()

BUG=702708
TEST=webaudio/unit-tests/audit.html
==========

to

==========
Implement ownProperty() and inheritFrom() assertions in should()

This CL add two assertions that abstracts the checks for JavaScript
traits.

 - should().ownProperty()
 - should().inheritFrom()

BUG=702708
TEST=webaudio/unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2805773002
Cr-Commit-Position: refs/heads/master@{#462970}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7faac578f403d2a6bb4a7675786...
==========

[commit-bot: I haz the power, 2017-04-07 19:49:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7faac578f403d2a6bb4a7675786...