third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoParallelRequests.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoParallelRequests.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Synchronize latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoSequentialRequests.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoSequentialRequests.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>

	3 Keyboard Lock - The second of two parallel requests should be rejected
	foolip 2017/04/17 08:46:04 The spec doesn't return a promise and thus doesn't The spec doesn't return a promise and thus doesn't describe this behavior. Please update the spec to match what you intend to implement. (It is of course OK for the implementation to be ahead of the spec sometimes, but it creates the risk that they're never made to align again, and should ideally come with plenty of TODOs that cannot be missed before shipping.) Hzj_jie 2017/04/18 02:26:08 I have added TODO in the idl file. Once we ship it Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > The spec doesn't return a promise and thus doesn't describe this behavior. > Please update the spec to match what you intend to implement. (It is of course > OK for the implementation to be ahead of the spec sometimes, but it creates the > risk that they're never made to align again, and should ideally come with plenty > of TODOs that cannot be missed before shipping.) I have added TODO in the idl file. Once we ship it, the flag will be removed from idl file, so the TODOs won't be missed.
	4 </title>

	5 <script src="/resources/testharness.js"></script>

	6 <script src="/resources/testharnessreport.js"></script>

	7 <script>

	8 'use strict';

	9

	10 promise_test((t) => {

	11 const p1 = navigator.requestKeyLock(['a', 'b']);

	12 const p2 = navigator.requestKeyLock(['c', 'd']);

	13 return promise_rejects(t, null, p2,

	14 'requestKeyLock() should only be ' +

	15 'executed if another request has finished.');

	16 }, 'Keyboard Lock requestKeyLock twice concurrently test');

	17

	18 </script>

OLD	NEW