On 2017/04/17 08:46:04, foolip_UTC7 wrote:
> Ditto about this name not being in the spec.
Yes, Gary is changing the spec.
10 .then(() => {})
foolip
2017/04/17 08:46:04
I think you can omit both the .then and the .catch
I think you can omit both the .then and the .catch line. If the returned promise
is resolved the test will pass, and if it's rejected the test will fail, the
promise_test machinery takes care of that.
On 2017/04/17 08:46:04, foolip_UTC7 wrote:
> I think you can omit both the .then and the .catch line. If the returned
promise
> is resolved the test will pass, and if it's rejected the test will fail, the
> promise_test machinery takes care of that.
Done.
11 .catch((reason) => {
12 assert_true(false, 'requestKeyLock should succeed: ' + reason);
13 });
14 }, 'Keyboard Lock requestKeyLock test');
foolip
2017/04/17 08:46:04
Ditto about having just one title in the file.
Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost
(Closed)
Created 3 years, 8 months ago by Hzj_jie
Modified 3 years, 7 months ago
Reviewers: whywhat, Avi (use Gerrit), dcheng, foolip, haraken, esprehn
Base URL:
Comments: 209