third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Synchronize latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.html ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Keyboard Lock - Interface</title>
	foolip 2017/04/17 08:46:04 Pleas exclude "test" from the filename, just metho Pleas exclude "test" from the filename, just methodName.https.html to match the method under test would be OK. Or navigator-methodName.https.html perhaps. Hzj_jie 2017/04/18 02:26:07 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > Pleas exclude "test" from the filename, just methodName.https.html to match the > method under test would be OK. Or navigator-methodName.https.html perhaps. Done.
	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6 'use strict';

	7

	8 test(() => {

	9 navigator.cancelKeyLock();
	foolip 2017/04/17 08:46:04 https://garykac.github.io/system-keyboard-lock/ do https://garykac.github.io/system-keyboard-lock/ doesn't have a cancelKeyLock() method, can you update the spec if you've all agreed to the name change? You could also assert that the return value is undefined so that if it's changed to return a promise, this test also has to be updated. Hzj_jie 2017/04/18 02:26:07 Yes, Gary is working on changing the spec. There a Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > https://garykac.github.io/system-keyboard-lock/ doesn't have a cancelKeyLock() > method, can you update the spec if you've all agreed to the name change? > > You could also assert that the return value is undefined so that if it's changed > to return a promise, this test also has to be updated. Yes, Gary is working on changing the spec. There are also several other changes required.
	10 }, 'Keyboard Lock cancelKeyLock test');
	foolip 2017/04/17 08:46:04 Omit "test" from titles as well. Since this is the Omit "test" from titles as well. Since this is the only test in the file, you can move the title into <title>. Or omit <title>, in any case two titles aren't useful. Hzj_jie 2017/04/18 02:26:07 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > Omit "test" from titles as well. Since this is the only test in the file, you > can move the title into <title>. Or omit <title>, in any case two titles aren't > useful. Done.
	11

	12 </script>

OLD	NEW