Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2805763002: DevTools: Use ToolbarMenuButton for MainMenuItem (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use ToolbarMenuButton for MainMenuItem This makes the MainMenuItem accessible with a keyboard. BUG=708902 Review-Url: https://codereview.chromium.org/2805763002 Cr-Commit-Position: refs/heads/master@{#462717} Committed: https://chromium.googlesource.com/chromium/src/+/2944ef043f8df7c39bef5e40ae95c2ad49c232f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-06 21:08:26 UTC) #3
dgozman
lgtm
3 years, 8 months ago (2017-04-06 21:27:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805763002/1
3 years, 8 months ago (2017-04-06 22:58:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805763002/1
3 years, 8 months ago (2017-04-06 23:52:51 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:50:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2944ef043f8df7c39bef5e40ae95...

Powered by Google App Engine
This is Rietveld 408576698