Remove SquareInkDropRipple::AnimateToCenterPoint

Remove SquareInkDropRipple::AnimateToCenterPoint

This was always animating to the same point; i.e. no effective change
was made after the initial transform on the root layer.

I discovered this while investigating the linked bug and it will make
my next fix easier, but in itself it should have no behavioral impact.

BUG=706228
Review-Url: https://codereview.chromium.org/2805753002
Cr-Commit-Position: refs/heads/master@{#463717}
Committed: https://chromium.googlesource.com/chromium/src/+/73ce931e71d004ae9028b75fb7fbe3c68f8538f4

[Evan Stade, 2017-04-06 20:08:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:09:09]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-04-07 15:17:21]

estade@chromium.org changed reviewers:
+ bruthig@chromium.org

[Evan Stade, 2017-04-11 17:12:56]

ping

[bruthig, 2017-04-11 17:23:44]

Sorry for the delay, this got lost in my mountain of e-mail.  Thanks for the
ping.

LGTM with nit.

https://codereview.chromium.org/2805753002/diff/1/ui/views/animation/square_i...
File ui/views/animation/square_ink_drop_ripple.h (right):

https://codereview.chromium.org/2805753002/diff/1/ui/views/animation/square_i...
ui/views/animation/square_ink_drop_ripple.h:174: const gfx::Point
target_center_point_;
nit: Remove

[Evan Stade, 2017-04-11 18:01:27]

https://codereview.chromium.org/2805753002/diff/1/ui/views/animation/square_i...
File ui/views/animation/square_ink_drop_ripple.h (right):

https://codereview.chromium.org/2805753002/diff/1/ui/views/animation/square_i...
ui/views/animation/square_ink_drop_ripple.h:174: const gfx::Point
target_center_point_;
On 2017/04/11 17:23:43, bruthig wrote:
> nit: Remove

we'll need to bring it back in the next CL but done.

[Evan Stade, 2017-04-11 18:01:31]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-04-11 18:01:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2805753002/#ps20001
(title: "remove member and superfluous ctor")

[commit-bot: I haz the power, 2017-04-11 18:02:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:18:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491933691337510,
"parent_rev": "e273f491f6560c00a26caf5551d76c286294cf5a", "commit_rev":
"73ce931e71d004ae9028b75fb7fbe3c68f8538f4"}

[commit-bot: I haz the power, 2017-04-11 19:19:41]

Description was changed from

==========
Remove SquareInkDropRipple::AnimateToCenterPoint

This was always animating to the same point; i.e. no effective change
was made after the initial transform on the root layer.

I discovered this while investigating the linked bug and it will make
my next fix easier, but in itself it should have no behavioral impact.

BUG=706228
==========

to

==========
Remove SquareInkDropRipple::AnimateToCenterPoint

This was always animating to the same point; i.e. no effective change
was made after the initial transform on the root layer.

I discovered this while investigating the linked bug and it will make
my next fix easier, but in itself it should have no behavioral impact.

BUG=706228

Review-Url: https://codereview.chromium.org/2805753002
Cr-Commit-Position: refs/heads/master@{#463717}
Committed:
https://chromium.googlesource.com/chromium/src/+/73ce931e71d004ae9028b75fb7fb...
==========

[commit-bot: I haz the power, 2017-04-11 19:19:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73ce931e71d004ae9028b75fb7fb...