ash/common/system/ime/tray_ime_chromeos.cc - Issue 2805733002: [Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/ime/tray_ime_chromeos.cc

Issue 2805733002: [Ash] Use DCHECK in ImeListView::HandleButtonPressed() (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/ime/tray_ime_chromeos.cc

diff --git a/ash/common/system/ime/tray_ime_chromeos.cc b/ash/common/system/ime/tray_ime_chromeos.cc

index e395bd20e66088e7f48ebd2657e8e28eba74ede5..7317d7c62c7f010f7038e8e2f04b18099aa79a82 100644

--- a/ash/common/system/ime/tray_ime_chromeos.cc

+++ b/ash/common/system/ime/tray_ime_chromeos.cc

@@ -103,9 +103,10 @@ class IMEDetailedView : public ImeListView {

void HandleButtonPressed(views::Button* sender,

const ui::Event& event) override {

- ImeListView::HandleButtonPressed(sender, event);

if (sender == settings_button_)

ShowSettings();

+ else

+ ImeListView::HandleButtonPressed(sender, event);

}

void CreateExtraTitleRowButtons() override {