Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_list_view.cc

Issue 2805733002: [Ash] Use DCHECK in ImeListView::HandleButtonPressed() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/system/ime/tray_ime_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/ime_menu/ime_list_view.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_list_view.cc b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
index be058a0ef81b2fb08f1ed1ebf16f06841ab5f1d9..b741564c4cf9ef1b4624b5b3f7e1c7de246b6fce 100644
--- a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
@@ -309,11 +309,11 @@ void ImeListView::HandleViewClicked(views::View* view) {
void ImeListView::HandleButtonPressed(views::Button* sender,
const ui::Event& event) {
- if (keyboard_status_row_ && sender == keyboard_status_row_->toggle()) {
- WmShell::Get()->ToggleIgnoreExternalKeyboard();
- last_selected_item_id_.clear();
- last_item_selected_with_keyboard_ = false;
- }
+ DCHECK(sender == keyboard_status_row_->toggle());
Evan Stade 2017/04/06 19:02:10 DCHECK_EQ?
tdanderson 2017/04/13 15:20:08 Done.
+
+ WmShell::Get()->ToggleIgnoreExternalKeyboard();
+ last_selected_item_id_.clear();
+ last_item_selected_with_keyboard_ = false;
}
void ImeListView::VisibilityChanged(View* starting_from, bool is_visible) {
« no previous file with comments | « no previous file | ash/common/system/ime/tray_ime_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698